Avoid copying a limit to query protobuf unless explicitly passed. by tseaver · Pull Request #492 · googleapis/google-cloud-python · GitHub

Fixes #491.

LGTM pending Travis

Feel free to merge

Coverage remained the same when pulling ec1bb14 on tseaver:491-fix_query_wo_limit into 22c8b19 on GoogleCloudPlatform:master.

Avoid copying a limit to query protobuf unless explicitly passed.

* Add handwritten model API classes. These classes provide the top-level classes for the Model API. The protocol buffer objects are used for all sub-objects. The pattern for mutable properties follows the same as with Table and Dataset: a `_properties` dictionary contains the property values in the REST API format. * Address review comments in Model. Use setdefault for labels. Simplify setter logic for expires. * Combine error messages for too many and too few parts in model/table ID.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* chore: fix proto formatting PiperOrigin-RevId: 503230949 Source-Link: googleapis/googleapis@55dd4d7 Source-Link: googleapis/googleapis-gen@588ff38 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTg4ZmYzOGNmM2EyZGQyMjY0ZGE1YjAzMGQxZjcyZTU2YzdmZmM2NiJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97

- [ ] Regenerate this pull request now. PiperOrigin-RevId: 472772457 Source-Link: googleapis/googleapis@855b74d Source-Link: googleapis/googleapis-gen@b64b1e7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjY0YjFlN2RhM2UxMzhmMTVjYTM2MTU1MmVmMDU0NWU1NDg5MWI0ZiJ9

* chore: Update gapic-generator-python to v1.11.2 PiperOrigin-RevId: 546510849 Source-Link: googleapis/googleapis@736073a Source-Link: googleapis/googleapis-gen@deb64e8 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGViNjRlOGVjMTlkMTQxZTMxMDg5ZmU5MzJiM2E5OTdhZDU0MWM0ZCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…ns (#492) * fix: correctly transform query job timeout configuration and exceptions * unit tests for configuration transformations * add unit tests for timeout * link todo to relevant issue * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * use correct template for freezegun deps * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * decrease tick time in case multiple time calls are made * try no tick * add freezegun to conda deps * typo Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> * typo Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>

🤖 I have created a release *beep* *boop* --- ### [0.17.4](googleapis/python-bigquery-pandas@v0.17.3...v0.17.4) (2022-03-14) ### Bug Fixes * avoid deprecated "out-of-band" authentication flow ([#500](googleapis/python-bigquery-pandas#500)) ([4758e3a](googleapis/python-bigquery-pandas@4758e3a)) * correctly transform query job timeout configuration and exceptions ([#492](googleapis/python-bigquery-pandas#492)) ([d8c3900](googleapis/python-bigquery-pandas@d8c3900)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Bump to use 0.11.0

* fix: fix 'Couldn't build proto file' when using Python 3.13 * fix: fix 'Couldn't build proto file' when using Python 3.13 * add comment

Fixes: #449, #492

Source-Link: googleapis/synthtool@50db768 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e09366bdf0fd9c8976592988390b24d53583dd9f002d476934da43725adbb978

Source-Link: googleapis/synthtool@d52e638 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:4f9b3b106ad0beafc2c8a415e3f62c1a0cc23cabea115dbe841b848f581cfe99 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…492)

This PR also switches the post processor image from `gcr.io/cloud-devrel-public-resources/owlbot-python:latest` to `gcr.io/repo-automation-bots/owlbot-python:latest` as there is a bug in owlbot where it only opens PRs when the post processor image is in the project `repo-automation-bots`. I've bumped the priority of the bug to p1 here: googleapis/repo-automation-bots#1790

…495) ## Summary Fixes #491. Supersedes #492 (stale). `urllib3 >= 2.6.0` now passes `max_length` to `decoder.decompress()` and accesses `decoder.has_unconsumed_tail`. Our custom `_GzipDecoder` and `_BrotliDecoder` wrappers didn't accept these, causing `TypeError` at runtime. This PR: - Updates `_GzipDecoder.decompress` and `_BrotliDecoder.decompress` to accept and forward `max_length`, with a `TypeError` fallback for older urllib3 - Adds `has_unconsumed_tail` property to `_BrotliDecoder` (the proxy class that needs it explicitly) - Applies the same fix to the async `_GzipDecoder` in `google/_async_resumable_media/` - Adds test coverage for the new `max_length` forwarding, the fallback path, and `has_unconsumed_tail` ## Feedback from #492 addressed - **`max_length=-1` default** (chandra-siri) — uses `-1` to match [urllib3's default](https://github.com/urllib3/urllib3/blob/bfe8e198a13800e3ee8ef8124a8928acb170c843/src/urllib3/response.py#L55), not `None` - **`has_unconsumed_tail` only on `_BrotliDecoder`** (chandra-siri) — `_GzipDecoder` inherits this from the parent `urllib3.response.GzipDecoder`, so no override is needed - **Lint failure** (BrennaEpp) — no trailing whitespace - **Missing test coverage for fallback paths** (BrennaEpp) — added tests for `max_length` forwarding, `TypeError` fallback, and `has_unconsumed_tail` (with `AttributeError` fallback for older urllib3) ## Test plan - [x] `pytest tests/unit/requests/test_download.py` — all pass - [x] `pytest tests_async/unit/requests/test_download.py` — all pass - [x] Full unit suite (514 tests) — all pass - [x] No lint issues (flake8 clean) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>

* docs: add samples for Spanner-specific features * docs: more samples * docs: add more samples * test: add tests for samples * chore: fix linting error * docs: document samples * docs: link to README

Avoid copying a limit to query protobuf unless explicitly passed.

ec1bb14

Fixes #491.

tseaver added a commit that referenced this pull request Jan 6, 2015

Merge pull request #492 from tseaver/491-fix_query_wo_limit

9b64977

Avoid copying a limit to query protobuf unless explicitly passed.

tseaver merged commit 9b64977 into googleapis:master Jan 6, 2015

tseaver deleted the 491-fix_query_wo_limit branch January 7, 2015 00:00

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore(main): release 2.17.3 (#492 )

2c0af3f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(main): release 2.17.3 (#492 )

3f33c42

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(main): release 2.17.3 (#492 )

7369b5a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(main): release 2.17.3 (#492 )

f6b4b40

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency flask to v2.1.0 (#492 )

ca85502

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update dependency google-cloud-pubsub to v2.18.3 (#492 )

7d6ee55

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(deps): update all dependencies (#492 )

5e5cefd

parthea pushed a commit that referenced this pull request Oct 21, 2023

chore(deps): update dependency google-cloud-vision to v3.1.3 (#492 )

4a33d20

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 2.17.3 (#492 )

5357685

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Aug 21, 2025

chore(deps): update dependency google-auth to v2.11.0 (#492 )

5e3ec21

parthea pushed a commit that referenced this pull request Sep 16, 2025

chore(deps): update dependency google-auth to v2.11.0 (#492 )

2d6fcc4

parthea pushed a commit that referenced this pull request Nov 24, 2025

chorse: update showcase version in circleci (#492 )

0fbf52d

Bump to use 0.11.0

parthea added a commit that referenced this pull request Nov 24, 2025

fix: fix 'Couldn't build proto file' when using Python 3.13 (#492 )

ccbfd45

* fix: fix 'Couldn't build proto file' when using Python 3.13 * fix: fix 'Couldn't build proto file' when using Python 3.13 * add comment

parthea pushed a commit that referenced this pull request Nov 24, 2025

test: switch to regex rather than asserting against whole object (#497 )

5b18e93

Fixes: #449, #492

parthea added a commit that referenced this pull request Nov 24, 2025

chore: add default_version and codeowner_team to repo-metadata.json (#…

5cc21ae

…492)

Avoid copying a limit to query protobuf unless explicitly passed. by tseaver · Pull Request #492 · googleapis/google-cloud-python · GitHub

Uh oh!

Avoid copying a limit to query protobuf unless explicitly passed. - #492

Avoid copying a limit to query protobuf unless explicitly passed.#492
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:491-fix_query_wo_limit

tseaver commented Jan 6, 2015

Uh oh!

dhermes commented Jan 6, 2015

Uh oh!

dhermes commented Jan 6, 2015

Uh oh!

coveralls commented Jan 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Avoid copying a limit to query protobuf unless explicitly passed. by tseaver · Pull Request #492 · googleapis/google-cloud-python · GitHub

Uh oh!

Avoid copying a limit to query protobuf unless explicitly passed. - #492

Avoid copying a limit to query protobuf unless explicitly passed.#492tseaver merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-python:masterfrom tseaver:491-fix_query_wo_limitCopy head branch name to clipboard

Conversation

tseaver commented Jan 6, 2015

Uh oh!

dhermes commented Jan 6, 2015

Uh oh!

dhermes commented Jan 6, 2015

Uh oh!

coveralls commented Jan 6, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Avoid copying a limit to query protobuf unless explicitly passed.#492
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:491-fix_query_wo_limit