FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

477: Prepare to remove dataset by tseaver · Pull Request #499 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

477: Prepare to remove dataset - #499

Closed
tseaver wants to merge 9 commits into
googleapis:masterfrom
tseaver:477-prepare_to_remove_dataset
ConversationCommits (9)ChecksFiles changed
Closed

477: Prepare to remove dataset#499
tseaver wants to merge 9 commits into
googleapis:masterfrom
tseaver:477-prepare_to_remove_dataset

Conversation

tseaver commented Jan 7, 2015

Copy link
Copy Markdown
Contributor
  • Don't document use of 'Dataset' or its factory methods.
  • Ensure that we have an implicit dataset ID.
  • Ensure that Key.__init__ uses implicit dataset ID when appropriate.

Toward #477, step 8.

tseaver changed the title 477 prepare to remove dataset 477: Prepare to remove dataset Jan 7, 2015

dhermes commented Jan 7, 2015

Copy link
Copy Markdown
Contributor

@tseaver I'm also working on this (I am the assignee on #477, sorry for not communicating that I was working on it)

dhermes reviewed Jan 7, 2015
View reviewed changes
Comment thread gcloud/datastore/key.py Outdated

This comment was marked as spam.

Sign in to view

dhermes mentioned this pull request Jan 7, 2015
Merged
tseaver added 5 commits January 7, 2015 14:30
Overlooked coverage foul.
99af098
Remove dead fixture.
57e179b
Rework '_require_dataset' -> '_require_dataset_id'.
ad78f59 
Also, make both it and '_require_connection' take the passed object,
and test explicitly against None.
Add 'set_default_dataset_id' helper.
ce5a207 
Will replace 'set_default_dataset'.
Valet service.
8baf341

tseaver commented Jan 7, 2015

Copy link
Copy Markdown
Contributor Author

Sorry for the clash: I was trying to nibble at the edges to remove more usage of Dataset before we actually removed the module.

dhermes commented Jan 7, 2015

Copy link
Copy Markdown
Contributor

No worries. What do you want to do? RE: #500

coveralls commented Jan 7, 2015

Copy link
Copy Markdown

Coverage remained the same when pulling 8baf341 on tseaver:477-prepare_to_remove_dataset into f176098 on GoogleCloudPlatform:master.

tseaver commented Jan 7, 2015

Copy link
Copy Markdown
Contributor Author

Why don't we go ahead with #500: we can eyeball / cherrypick this one as needed.

tseaver closed this Jan 7, 2015

dhermes commented Jan 7, 2015

Copy link
Copy Markdown
Contributor

Thanks

tseaver deleted the 477-prepare_to_remove_dataset branch January 7, 2015 20:34
tseaver added a commit that referenced this pull request Jan 7, 2015
Merge pull request #501 from tseaver/cherrypick-499
0eca209 
Cherry pick cleanups from #499.
dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
chore(main): release 2.18.0 (#499)
b30fdff 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
chore(main): release 2.18.0 (#499)
a6fb3a8 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
chore(main): release 2.18.0 (#499)
1dd11ae 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
chore(main): release 2.18.0 (#499)
c6b7881 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
chore(deps): update dependency google-cloud-dialogflow-cx to v1.18.0 (#…
ccb5e8a 
…499)
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(samples): Adds code examples to create, get, list, update and d…
1df7389 
…elete a SavedQuery (#499)

* Change the comment of BatchGetEffectiveIamPolicies to be more accurate.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_update_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_update_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_update_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_create_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_delete_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_delete_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_get_saved_query_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* Update samples/snippets/quickstart_list_saved_queries_test.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* feat: Adds code examples to create, get, list, update and delete a SavedQuery.

* Update samples/snippets/quickstart_create_saved_query.py

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(deps): update dependency backoff to v2.2.1 (#499)
4bdb89e
parthea pushed a commit that referenced this pull request Oct 21, 2023
chore(deps): update dependency pillow to v9.3.0 (#499)
78f777c
parthea pushed a commit that referenced this pull request Oct 22, 2023
chore(main): release 2.18.0 (#499)
046a200 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 21, 2025
ci(python): fix path to requirements.txt in release script (#499)
9d94c8e 
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Sep 16, 2025
ci(python): fix path to requirements.txt in release script (#499)
0851820 
Source-Link: googleapis/synthtool@fdba3ed
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
parthea pushed a commit that referenced this pull request Sep 18, 2025
chore(main): release 0.17.4 (#499)
a718cbf 
🤖 I have created a release *beep* *boop*
---


### [0.17.4](googleapis/python-bigquery-pandas@v0.17.3...v0.17.4) (2022-03-14)


### Bug Fixes

* avoid deprecated "out-of-band" authentication flow ([#500](googleapis/python-bigquery-pandas#500)) ([4758e3a](googleapis/python-bigquery-pandas@4758e3a))
* correctly transform query job timeout configuration and exceptions ([#492](googleapis/python-bigquery-pandas#492)) ([d8c3900](googleapis/python-bigquery-pandas@d8c3900))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: release 0.26.1 (#499)
a10685a 
* updated CHANGELOG.md [ci skip]

* updated setup.py

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
fix: Sets cache support to false, removes upper req limit (#499)
9d9bd2e 
* Sets cache support to false, removes upper req limit

* fix: Sets cache support to false, removes upper req limit

* Removes OBE comments regarding max version number
parthea pushed a commit that referenced this pull request Nov 24, 2025
feat: add new_transaction support (#499)
1bf801a
parthea pushed a commit that referenced this pull request Nov 24, 2025
testing: use pytest idioms for unit tests (#499)
be39005
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore(deps): update dependency google-cloud-pubsub to v2.11.0 (#499)
18410ae 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-pubsub](https://togithub.com/googleapis/python-pubsub) | `==2.10.0` -> `==2.11.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/compatibility-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/confidence-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-pubsub</summary>

### [`v2.11.0`](https://togithub.com/googleapis/python-pubsub/blob/HEAD/CHANGELOG.md#&#8203;2110-httpsgithubcomgoogleapispython-pubsubcomparev2100v2110-2022-03-09)

[Compare Source](https://togithub.com/googleapis/python-pubsub/compare/v2.10.0...v2.11.0)

##### Features

-   retry temporary GRPC statuses for ack/modack/nack when exactly-once delivery is enabled ([#&#8203;607](https://togithub.com/googleapis/python-pubsub/issues/607)) ([a91bed8](https://togithub.com/googleapis/python-pubsub/commit/a91bed829c9040fcc6c1e70b99b66188ac4ded40))
-   return singleton success future for exactly-once methods in Message ([#&#8203;608](https://togithub.com/googleapis/python-pubsub/issues/608)) ([253ced2](https://togithub.com/googleapis/python-pubsub/commit/253ced28f308450c7a1a93cc38f6d101ecd7d4c0))

##### Bug Fixes

-   **deps:** require google-api-core>=1.31.5, >=2.3.2 ([#&#8203;600](https://togithub.com/googleapis/python-pubsub/issues/600)) ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))
-   **deps:** require proto-plus>=1.15.0 ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-logging).
parthea pushed a commit that referenced this pull request Nov 25, 2025
chore(deps): update dependency google-cloud-pubsub to v2.11.0 (#499)
9c07482 
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [google-cloud-pubsub](https://togithub.com/googleapis/python-pubsub) | `==2.10.0` -> `==2.11.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/compatibility-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-cloud-pubsub/2.11.0/confidence-slim/2.10.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/python-pubsub</summary>

### [`v2.11.0`](https://togithub.com/googleapis/python-pubsub/blob/HEAD/CHANGELOG.md#&#8203;2110-httpsgithubcomgoogleapispython-pubsubcomparev2100v2110-2022-03-09)

[Compare Source](https://togithub.com/googleapis/python-pubsub/compare/v2.10.0...v2.11.0)

##### Features

-   retry temporary GRPC statuses for ack/modack/nack when exactly-once delivery is enabled ([#&#8203;607](https://togithub.com/googleapis/python-pubsub/issues/607)) ([a91bed8](https://togithub.com/googleapis/python-pubsub/commit/a91bed829c9040fcc6c1e70b99b66188ac4ded40))
-   return singleton success future for exactly-once methods in Message ([#&#8203;608](https://togithub.com/googleapis/python-pubsub/issues/608)) ([253ced2](https://togithub.com/googleapis/python-pubsub/commit/253ced28f308450c7a1a93cc38f6d101ecd7d4c0))

##### Bug Fixes

-   **deps:** require google-api-core>=1.31.5, >=2.3.2 ([#&#8203;600](https://togithub.com/googleapis/python-pubsub/issues/600)) ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))
-   **deps:** require proto-plus>=1.15.0 ([1608b7f](https://togithub.com/googleapis/python-pubsub/commit/1608b7ffdd5b5db87e1e55fde763440ca9a4086e))

</details>

---

### Configuration

📅 **Schedule**: At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/python-logging).
parthea pushed a commit that referenced this pull request Mar 2, 2026
process: add type annotations check to CI runs (#499)
6e1dbb8 
* Add pytype nox session

* Disable false pytype positives in types.py

* 🦉 Updates from OwlBot

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
chore: update blunderbuss config with new teams (#499)
1bfd9a7 
b/478003109
parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency packaging to v24.2 (#499)
cb61a26
parthea pushed a commit that referenced this pull request Mar 9, 2026
tests: suppress deprecation warnings in unit test output (#499)
78e6c2b 
Test hygeine: avoid importing module-under-test at module scope

Closes #498.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: datastore Issues related to the Datastore API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL