FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

api_core: fix import order, appeasing lint. by tseaver · Pull Request #6240 · googleapis/google-cloud-python · GitHub

api_core: fix import order, appeasing lint. - #6240

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:6211-api_core-fix_lint
Oct 17, 2018
Merged

api_core: fix import order, appeasing lint.#6240
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:6211-api_core-fix_lint

Conversation

tseaver commented Oct 17, 2018
edited
Loading

Copy link
Copy Markdown
Contributor

Error left from PR #6211, when Kokoro was blithely skipping tests.
tseaver requested a review from crwilcox October 17, 2018 19:13
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2018

tseaver commented Oct 17, 2018

Copy link
Copy Markdown
Contributor Author

@crwilcox the kokoro build for api_core is failing for what look like spurious branch coverage issues: both of the lines are in the middle of functions, with no branch point in sight.

tseaver commented Oct 17, 2018

Copy link
Copy Markdown
Contributor Author

I'm merging anyway to fix the lint import bit on master.

tseaver merged commit f0449e0 into googleapis:master Oct 17, 2018
tseaver deleted the 6211-api_core-fix_lint branch October 17, 2018 19:31

tseaver commented Oct 17, 2018

Copy link
Copy Markdown
Contributor Author

@crwilcox The branch coverage failures are for the lambda _: True callbacks passed in to bidi.ResumableBidiRpc() ?!?

parthea pushed a commit that referenced this pull request Nov 24, 2025
Error left from PR #6211, when Kokoro was blithely skipping tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: core cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL