FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Move bidi to api-core by crwilcox · Pull Request #6211 · googleapis/google-cloud-python · GitHub

Move bidi to api-core - #6211

Merged
crwilcox merged 3 commits into
googleapis:masterfrom
crwilcox:move-bidi
Oct 16, 2018
Merged

Move bidi to api-core#6211
crwilcox merged 3 commits into
googleapis:masterfrom
crwilcox:move-bidi

Conversation

Copy link
Copy Markdown
Contributor

No description provided.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2018
crwilcox requested a review from theacodes October 15, 2018 17:00

tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like you meant to move bidi.py into api_core/google/api_core/, rahter than core/google/cloud (at least, that is what the import changes say).

Copy link
Copy Markdown

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 15, 2018

Copy link
Copy Markdown
Contributor Author

@tseaver 100% correct. That was an error on my part.

tseaver commented Oct 16, 2018

Copy link
Copy Markdown
Contributor

@crwilcox, @theacodes please clear the CLA flag and merge.

crwilcox added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 16, 2018

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

crwilcox merged commit 92a6380 into googleapis:master Oct 16, 2018
tseaver added a commit that referenced this pull request Oct 17, 2018
Error left from PR #6211, when Kokoro was blithely skipping tests.
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Error left from PR #6211, when Kokoro was blithely skipping tests.
parthea pushed a commit that referenced this pull request Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL