BigQuery: add destination table properties to 'LoadJobConfig'. - #6202
Merged
tseaver merged 26 commits intoOct 17, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tswast
approved these changes
Oct 15, 2018
tswast
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Thanks!
Sorry, something went wrong.
Comment thread
bigquery/google/cloud/bigquery/job.py
Outdated
Comment thread
bigquery/tests/unit/test_job.py
Outdated
Copy link
Copy Markdown
Contributor
Author
|
Merge blocked pending resolution of #6231, and a re-run of the Kokoro Bigquery job (how?). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
None are relevant to this PR, which is purely BigQuery. @theacodes looks like Kokoro has gone from skipping everything (#6231) to running all tests regardless? |
Sorry, something went wrong.
Note question posted to issue #5093: should 'max_bad_rows' and 'skip_leading_rows' match in how the mangle / parse the value in the resource? Docs say it is an integer.
…ryption_configuration'.
It should remove the 'timePartitioning' sub-key altogether.
… LJC tests. Fix bug revealed thereby in 'LJC.destination_encryption_configuration' setter.
tseaver
force-pushed
the
5093-bigquery-destination_table_props
branch
from
554b323 to
2a920d1
Compare
October 17, 2018 20:03
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5093.
This PR includes a bunch of new explicit unit test cases / assertions for LoadJobConfig, and reorders the properties alphabetically, to make it easier to match up with the docs.
/cc @yiga2.