Fix branch coverage for un-called callbacks. - #6242
Merged
tseaver merged 1 commit intoOct 17, 2018
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Use 'mock.Mock()' w/ 'return_value' True, rather than inlining 'lambda _: True' in cases where the callback doesn't get called.
Copy link
Copy Markdown
Contributor
Author
|
Merging w/o review: testing only fix for broken api_core CI on master. |
Sorry, something went wrong.
This was referenced Oct 17, 2018
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Use 'mock.Mock()' w/ 'return_value' True, rather than inlining 'lambda _: True' in cases where the callback doesn't get called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use mock.Mock() w/ return_value True, rather than inlining lambda _: True in cases where the callback doesn't get called.