FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Adding back storage.lookup_bucket. by dhermes · Pull Request #700 · googleapis/google-cloud-python · GitHub

/ google-cloud-python Public

Adding back storage.lookup_bucket. - #700

Merged
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-back-storage-bucket-lookup
Mar 12, 2015
ConversationCommits (1)ChecksFiles changed
Merged

Adding back storage.lookup_bucket.#700
dhermes merged 1 commit into
googleapis:masterfrom
dhermes:add-back-storage-bucket-lookup

Conversation

dhermes commented Mar 12, 2015

Copy link
Copy Markdown
Contributor

This was originally removed in #588.

@tseaver I'd like to remove all the bucket functions from Connection and move them into api. WDYT?

Also it seems we'd eventually want to add a _require_connection as in datastore.api. It would be nice to come with a re-factor for re-usability (the Batch is the part which needs to be package specific).

FWIW: I came across this while trying to make implicit auth work in storage. Importing Connection in _implicit_environ creates a cycle, essentially because Connection imports Bucket.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 12, 2015

coveralls commented Mar 12, 2015

Copy link
Copy Markdown

Changes Unknown when pulling f50d036 on dhermes:add-back-storage-bucket-lookup into * on GoogleCloudPlatform:master*.

dhermes added the api: storage Issues related to the Cloud Storage API. label Mar 12, 2015

tseaver commented Mar 12, 2015

Copy link
Copy Markdown
Contributor

Moving the bucket-related functions to storage.api SGTM.

tseaver commented Mar 12, 2015

Copy link
Copy Markdown
Contributor

I'm not sure what the motivation is for re-adding the lookup_bucket() API.

dhermes commented Mar 12, 2015

Copy link
Copy Markdown
Contributor Author

@tseaver We don't need to add it back, but in the discussion in #588 you asked that we add it back, so I was trying to get the ball rolling with the storage.api module with something simple.

dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
STORAGE: Making Connection.get_all_buckets a standalone method.
9c78309 
See comments in googleapis#700 for context.
dhermes mentioned this pull request Mar 12, 2015
Merged

tseaver commented Mar 12, 2015

Copy link
Copy Markdown
Contributor

facepalm I should have gone back to look at #588.

LGTM.

dhermes added a commit that referenced this pull request Mar 12, 2015
Merge pull request #700 from dhermes/add-back-storage-bucket-lookup
39627c0 
Adding back storage.lookup_bucket.
dhermes merged commit 39627c0 into googleapis:master Mar 12, 2015

dhermes commented Mar 12, 2015

Copy link
Copy Markdown
Contributor Author

Cool. I'll rebase #716 now.

dhermes deleted the add-back-storage-bucket-lookup branch March 12, 2015 19:25
dhermes added a commit to dhermes/google-cloud-python that referenced this pull request Mar 12, 2015
STORAGE: Making Connection.get_all_buckets a standalone method.
4f0c483 
See comments in googleapis#700 for context.
dhermes mentioned this pull request Mar 12, 2015
Merged
parthea pushed a commit that referenced this pull request Nov 22, 2025
docs: update docs build (via synth) (#99)
490e9c7 
* feat(python-library): changes to docs job

* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Wed Jul 29 16:15:18 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: f07cb4446192952f19be3056957f56d180586055
Source-Link: googleapis/synthtool@f07cb44

* Revert "feat(python-library): changes to docs job (#700)"

This reverts commit f07cb4446192952f19be3056957f56d180586055.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Jul 29 17:33:57 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ee7506d15daa3873accfff9430eff7e3953f0248
Source-Link: googleapis/synthtool@ee7506d

* feat(python-library): changes to docs job

* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

* add a failing test first

* fix TemplateSyntaxError: Missing end of comment tag

* serving_path is not needed any more

* use `raw` to make jinja happy

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 12:44:02 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5dfda5621df45b71b6e88544ebbb53b1a8c90214
Source-Link: googleapis/synthtool@5dfda56

* fix(python-library): add missing changes

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 18:26:35 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 39b527a39f5cd56d4882b3874fc08eed4756cebe
Source-Link: googleapis/synthtool@39b527a

* chore(py_library): add split_system_tests

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Jul 31 16:17:13 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: bfcdbe0da977b2de6c1c0471bb6dc2f1e13bf669
Source-Link: googleapis/synthtool@bfcdbe0

* chore(py_library): add some excludes in docs/conf.py

This should fix build failures in python-bigquery.
Example:
googleapis/python-bigquery#205

* also add a comment

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Mon Aug 3 15:08:00 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 4f8f5dc24af79694887385015294e4dbb214c352
Source-Link: googleapis/synthtool@4f8f5dc

Co-authored-by: Tres Seaver <tseaver@palladion.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
chore: release 0.36.0 (#700)
5bbcdc6 
🤖 I have created a release \*beep\* \*boop\* 
---
## [0.36.0](https://www.github.com/googleapis/gapic-generator-python/compare/v0.35.11...v0.36.0) (2020-11-14)


### Features

* add rest transport generation for clients with optional transport flag ([#688](https://www.github.com/googleapis/gapic-generator-python/issues/688)) ([af59c2c](https://www.github.com/googleapis/gapic-generator-python/commit/af59c2c3c3d6b7e1f626c3fbc2c03f99ca31b4a4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please).
parthea added a commit that referenced this pull request Nov 24, 2025
feat: add support for asynchronous long running operations (#724)
b8ae912 
* feat: implement `OperationsRestAsyncTransport` to support long running operations (#700)

* feat: Add OperationsRestAsyncTransport to support long running operations

* update TODO comment

* update TODO comment

* address feedback

* address feedback

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* fix mypy and lint issues

* minor fix

* add no cover

* fix no cover tag

* link coverage issue

* silence coverage issue

* fix statement name error

* address PR feedback

* address PR feedback

* address PR comments

---------

Co-authored-by: ohmayr <omairnaveed@ymail.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat: implement async client for LROs (#707)

* feat: implement `AbstractOperationsAsyncClient` to support long running operations

* remove coverage guards

* address presubmit failures

* fix coverage for cancel operation

* tests cleanup

* fix incorrect tests

* file bugs

* add auth import

* address PR comments

* address PR comments

* fix unit tests and address more comments

* disable retry parameter

* add retry parameter

* address PR comments

---------

Co-authored-by: ohmayr <omairnaveed@ymail.com>
Co-authored-by: ohmayr <omairn@google.com>

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
docs: update docs build (via synth) (#58)
4af0932 
* changes without context

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.

* feat(python-library): changes to docs job

* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Wed Jul 29 16:15:18 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: f07cb4446192952f19be3056957f56d180586055
Source-Link: googleapis/synthtool@f07cb44

* Revert "feat(python-library): changes to docs job (#700)"

This reverts commit f07cb4446192952f19be3056957f56d180586055.

Source-Author: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
Source-Date: Wed Jul 29 17:33:57 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: ee7506d15daa3873accfff9430eff7e3953f0248
Source-Link: googleapis/synthtool@ee7506d

* feat(python-library): changes to docs job

* feat(python-library): changes to docs job

* migrate to Trampoline V2
* add docs-presubmit job
* create docfx yaml files and upload them to another bucket

* remove redundant envvars

* add a failing test first

* fix TemplateSyntaxError: Missing end of comment tag

* serving_path is not needed any more

* use `raw` to make jinja happy

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 12:44:02 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 5dfda5621df45b71b6e88544ebbb53b1a8c90214
Source-Link: googleapis/synthtool@5dfda56

* fix(python-library): add missing changes

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Thu Jul 30 18:26:35 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 39b527a39f5cd56d4882b3874fc08eed4756cebe
Source-Link: googleapis/synthtool@39b527a

* chore(py_library): add split_system_tests

Source-Author: Takashi Matsuo <tmatsuo@google.com>
Source-Date: Fri Jul 31 16:17:13 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: bfcdbe0da977b2de6c1c0471bb6dc2f1e13bf669
Source-Link: googleapis/synthtool@bfcdbe0

* chore: patch docs/conf.py manually

* docs: clean up docs/conf.py

Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
docs: Fix formatting of request arg in docstring (#700)
ef56d47 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Nov 24, 2025
feat: Add support for python 3.11 (#700)
c4d355e 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* require proto-plus 1.22.2 for python 3.11

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
test: fix flaky system test (#701)
2d68a31 
Normally a unique namespace per test run is used to prevent different
test runs from interfering with each other, but some tests are
specifically for the default namespace. A discriminator is added to this
test that allows us to narrow the test query to only entities created
in the current test run.

Fixes #700

Co-authored-by: Tres Seaver <tseaver@palladion.com>
parthea added a commit that referenced this pull request Nov 25, 2025
feat: Add support for python 3.11 (#700)
37d251c 
* feat: Add support for python 3.11

chore: Update gapic-generator-python to v1.8.0
PiperOrigin-RevId: 500768693

Source-Link: googleapis/googleapis@190b612

Source-Link: googleapis/googleapis-gen@7bf29a4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiN2JmMjlhNDE0YjllY2FjMzE3MGYwYjY1YmRjMmE5NTcwNWMwZWYxYSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* require proto-plus 1.22.2 for python 3.11

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
fix: session object was never used in aiohttp request (#700) (#701)
fd8efd1 
* fix: session object was never used in aiohttp request (#700)

* fixup! fix: session object was never used in aiohttp request (#700)

* fixup! fixup! fix: session object was never used in aiohttp request (#700)

Co-authored-by: arithmetic1728 <58957152+arithmetic1728@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 2, 2026
docs: fix changelog header to consistent size (#700)
82321f7
parthea added a commit that referenced this pull request Mar 6, 2026
chore: pin sphinx to version 4.0.1 (#701)
fd1f5d4 
* chore: pin sphinx to version 4.0.1

Fixes #700

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 6, 2026
Docs: fix changelog link and sample examples. (#700)
8057fab 
* docs: update docs to show decimal field support and check constraints but no support for unsigned data type

* docs: linked changelog correctly

* docs: fix doc links for sample examples

* fix: skip test cursor_executemany_with_empty_params_list as spanner support is not there
parthea pushed a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency urllib3 to v2.5.0 [security] (#700)
8228fa1
parthea added a commit that referenced this pull request Mar 9, 2026
chore(deps): update dependency pandas to v1.4.0 (#700)
a68a312 
* chore(deps): update dependency pandas to v1.4.0

* add pandas pin for python 3.7

* adjust pin

Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea added a commit that referenced this pull request Mar 9, 2026
chore(python): refactor unit / system test dependency install (#700)
09e2cf8 
* chore: upgrade black in noxfile.py to 22.3.0

Source-Link: googleapis/synthtool@0dcf739
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9ce2de2e0a59b6ae3b1eb216f441ee0dea59b1cfc08109d03613916d09d25a35

* ci: add extras for system tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL