STORAGE: Making Connection.get_all_buckets a standalone method. - #716
Merged
dhermes merged 1 commit intoMar 12, 2015
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
See comments in googleapis#700 for context.
dhermes
force-pushed
the
storage-move-get-all-buckets-to-api
branch
from
9c78309 to
4f0c483
Compare
March 12, 2015 19:33
Copy link
Copy Markdown
Contributor
|
LGTM. I would just move get_bucket, create_bucket, and delete_bucket in a single PR, though. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Cool. I'll wait on Travis before merging. We've also got a 3 PR backup in the "merged" queue: |
Sorry, something went wrong.
Copy link
Copy Markdown
|
Changes Unknown when pulling 4f0c483 on dhermes:storage-move-get-all-buckets-to-api into * on GoogleCloudPlatform:master*. |
Sorry, something went wrong.
dhermes
added a commit
that referenced
this pull request
Mar 12, 2015
STORAGE: Making Connection.get_all_buckets a standalone method.
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 12, 2015
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 12, 2015
This was referenced Mar 12, 2015
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Mar 13, 2015
parthea
pushed a commit
that referenced
this pull request
Sep 18, 2025
…716) Source-Link: googleapis/synthtool@280ddae Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:346ab2efb51649c5dde7756cbbdc60dd394852ba83b9bbffc292a63549f33c17 Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
* fix: updating testing, rest-only generation, & minor bug-fixes * test: test async client generation * fix: fixed reserved keyword bug, fixed bugs in gapic tests * fix: reverted bug causing change to , refactored template tests * fix: return type mismatch * fix: reserved keyword issue in * fix: replace bad regex checks with checks against field_pb type * Update gapic/templates/noxfile.py.j2 Co-authored-by: Dov Shlachter <dovs@google.com> Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
* feat: Replace utcnow and utcfromtimestamp These will be deprecated starting in Python 3.12. Replaced: - `datetime.datetime.utcnow()` with `datetime.datetime.now(tz=datetime.timezone.utc)` - `datetime.utcfromtimestamp()` with `datetime.fromtimestamp(tz=datetime.timezone.utc)` * docs: deprecate google.cloud.firestore_v1.rate_limiter.utcnow * remove usage of google.cloud.firestore_v1.rate_limiter.utcnow in code * filter deprecation warning for google.cloud.firestore_v1.rate_limiter.utcnow --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comments in #700 for context.
@tseaver I figured it would be easier to digest moving one method at a time instead of all 4 at once. Still remaining:
NOTE: I re-ran the storage demo to make sure this worked and noticed the very first line was the license. Without the opening
the demo is pretty tough to use. I can add the license back at the end of the file if necessary or even after # Welcome ... (/cc @jgeewax).