Using a fallback connection in Bucket - #759
Closed
dhermes wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Comment thread
gcloud/storage/api.py
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
dhermes
force-pushed
the
bucket-connection-fallback
branch
from
69c321f to
f19effa
Compare
March 28, 2015 18:12
dhermes
force-pushed
the
bucket-connection-fallback
branch
from
f19effa to
adc470b
Compare
March 28, 2015 18:13
Copy link
Copy Markdown
Contributor
Author
|
After discussing with @tseaver it has been determined that unbundling Connection and Bucket is possible, so I am closing this out. Will salvage some parts of it, like Bucket.create() and send out another PR. |
Sorry, something went wrong.
This was referenced Mar 30, 2015
parthea
pushed a commit
that referenced
this pull request
Aug 21, 2025
* chore(python): add requirements for docs build Source-Link: googleapis/synthtool@85c23b6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3741fd1f5f5150378563c76afa06bcc12777b5fe54c5ee01115218f83872134f * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea
pushed a commit
that referenced
this pull request
Sep 16, 2025
* chore(python): add requirements for docs build Source-Link: googleapis/synthtool@85c23b6 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3741fd1f5f5150378563c76afa06bcc12777b5fe54c5ee01115218f83872134f * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea
pushed a commit
that referenced
this pull request
Nov 22, 2025
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Nov 24, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
added a commit
that referenced
this pull request
Nov 25, 2025
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea
pushed a commit
that referenced
this pull request
Nov 26, 2025
Drop explicit pin / constraint on 'urllib3': specific 'requests' versions have very narrow pins, and ours is only likely to create conflicts. Bump the 'requests' lower bound to '2.20.0', the lowest version for which our tests pass once constraints are being checked. Closes #759
parthea
pushed a commit
that referenced
this pull request
Mar 2, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
Source-Link: googleapis/synthtool@53ea389 Post-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:e1793a23ae0ee9aafb2e3a53b564a351f74790dbe3c2d75f8fc3b8c43e5c036c
parthea
pushed a commit
that referenced
this pull request
Mar 6, 2026
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
Link formatting was causing the Blob module to not render correctly on c.g.c https://cloud.google.com/python/docs/reference/storage/latest/google.cloud.storage.blob Fix links according to python style guide and make the links more readable.
parthea
pushed a commit
that referenced
this pull request
Mar 9, 2026
* changes for testing in postgres * parametrized testing * parametrized testing * chore: correct skip backup tests env variable (#753) * increasing timeout * splitting tests * changes as per review * Revert "changes as per review" This reverts commit 63064c742d5c3cd4d79c592e07a14abc35c10bce. * Revert "splitting tests" This reverts commit ae49fde208cc2f3a29192d0650c36240e8fdb0c7. * skipping backup testing Co-authored-by: ansh0l <ansh0l@users.noreply.github.com>
parthea
added a commit
that referenced
this pull request
Mar 9, 2026
* chore(python): drop python 3.6 Source-Link: googleapis/synthtool@4f89b13 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c * add api_description to .repo-metadata.json * require python 3.7+ in setup.py * remove python 3.6 sample configs * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * exclude templated README * restore manual changes to noxfile.py * update owlbot.py to apply manual changes from #759 * regenerate pb2 files using latest version of grpcio tools Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com> Co-authored-by: Astha Mohta <35952883+asthamohta@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative fix to #728, by way of making connection be optional.
This has an effect of cascading through everything since ACL and Blob both use the connection of the Bucket.
Note especially the changes to get_bucket and create_bucket, which passes None through to the Bucket() constructor and lets the environment dictate the connection (e.g. in a batch).
@tseaver Do you think bucket.connection being a non-deterministic value will be confounding?