#825: Allow passing explicit connection to ACL.{reload,save} - #853
Conversation
Sorry, something went wrong.
Use new 'connection', 'reload_path', and 'save_path' properties to make the base class implementation generic.
|
Changes Unknown when pulling 0ed115b on tseaver:825-storage_acl-explicit_connection into * on GoogleCloudPlatform:master*. |
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
|
LGTM. @tseaver I'd like to have a pow-wow about the current state of our ACL support and try to figure out what we want (or better yet, what someone wants that's actually used ACLs for an application). Things are a bit out of place in the current state (e.g. roles is a set, but storage has a concept of concentric roles permissions for the very purpose of avoiding an ACL having more than one role). |
Sorry, something went wrong.
#825: Allow passing explicit connection to `ACL.{reload,save}`
|
It is annyoing that those docs can't keep role vs. permisison straight, even on the same page. If READER, WRITER, and OWNER are the only possible permissions / roles, then we could avoid having an ACE (a single assertion/entity, of which an ACL is a collection) have only one of them. |
Sorry, something went wrong.
|
We should also work out how to support the predefined ACLs feature |
Sorry, something went wrong.
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
* chore(deps): update all dependencies * pin pytest for python 3.7 --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* chore(deps): update all dependencies * pin pytest for python 3.7 --------- Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
The backend API has a timeout of 4 minutes, so the default of 2 minutes was not allowing for any retries to happen in some cases. Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) Fixes #853 🦕
* chore: use templated renovate.json * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
See #825