FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

#825: Allow passing explicit connection to pubsub API methods by tseaver · Pull Request #859 · googleapis/google-cloud-python · GitHub

#825: Allow passing explicit connection to pubsub API methods - #859

Merged
tseaver merged 9 commits into
googleapis:masterfrom
tseaver:825-pubsub-explicit_connection
May 6, 2015
Merged

#825: Allow passing explicit connection to pubsub API methods#859
tseaver merged 9 commits into
googleapis:masterfrom
tseaver:825-pubsub-explicit_connection

Conversation

tseaver commented May 4, 2015

Copy link
Copy Markdown
Contributor

See #825.

tseaver added the api: pubsub Issues related to the Pub/Sub API. label May 4, 2015
googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 4, 2015

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling b60cf16 on tseaver:825-pubsub-explicit_connection into 8b5c5b9 on GoogleCloudPlatform:master.

dhermes commented May 6, 2015

Copy link
Copy Markdown
Contributor

Overall no complaints, but we still have connection bound to our objects. What is the point of #825 without the context of #728 (or something like #728 for pubsub)?

tseaver added 2 commits May 6, 2015 10:06
Adopt '_require_connection' pattern from storage.

Addresses:
#859 (comment)

tseaver commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

@dhermes ad82cf7 removes all use of a .connection attribute / property in pubsub.

Copy link
Copy Markdown

Coverage remained the same at 100.0% when pulling ad82cf7 on tseaver:825-pubsub-explicit_connection into 8b5c5b9 on GoogleCloudPlatform:master.

dhermes commented May 6, 2015

Copy link
Copy Markdown
Contributor

LGTM

tseaver added a commit that referenced this pull request May 6, 2015
#825: Allow passing explicit connection to pubsub API methods
tseaver merged commit aafcd2a into googleapis:master May 6, 2015
tseaver deleted the 825-pubsub-explicit_connection branch May 6, 2015 20:50
parthea pushed a commit that referenced this pull request Nov 24, 2025
parthea pushed a commit that referenced this pull request Nov 24, 2025
Follow up to #859

Closes #815

Also delete a stray } in feature_fragments which was resulting in almost empty files getting generated in clients. https://github.com/googleapis/googleapis-gen/blob/master/google/appengine/v1/google-cloud-appengine-v1-py/examples/feature_fragments
parthea added a commit that referenced this pull request Nov 24, 2025
…y38/py39 (#859)

* fix: remove call to importlib.metadata.packages_distributions() for py38/py39

* cover

* update comment
parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea pushed a commit that referenced this pull request Feb 13, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.1
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>google-api-core: 2.29.0</summary>

##
[2.29.0](googleapis/python-api-core@v2.28.1...v2.29.0)
(2026-01-08)

### Features

* make parse_version_to_tuple public (#864)
([c969186f](googleapis/python-api-core@c969186f))

* Auto enable mTLS when supported certificates are detected (#869)
([f8bf6f96](googleapis/python-api-core@f8bf6f96))

### Bug Fixes

* remove call to importlib.metadata.packages_distributions() for
py38/py39 (#859)
([628003e2](googleapis/python-api-core@628003e2))

* Log version check errors (#858)
([6493118c](googleapis/python-api-core@6493118c))

* flaky tests due to imprecision in floating point calculation and
performance test setup (#865)
([93404080](googleapis/python-api-core@93404080))

* closes tailing streams in bidi classes. (#851)
([c97b3a00](googleapis/python-api-core@c97b3a00))

</details>
parthea pushed a commit that referenced this pull request Mar 6, 2026
The backend API has a timeout of 4 minutes, so the default of 2 minutes was not
allowing for any retries to happen in some cases.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #853  🦕
parthea pushed a commit that referenced this pull request Mar 6, 2026
Source-Link: googleapis/synthtool@d895aec
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:98f3afd11308259de6e828e37376d18867fd321aba07826e29e4f8d9cab56bad

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL