FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

added optional content_type to bucket.upload_file · Pull Request #883 · googleapis/google-cloud-python · GitHub

added optional content_type to bucket.upload_file - #883

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
Closed

added optional content_type to bucket.upload_file#883
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

ghost commented May 15, 2015

Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label May 15, 2015

ghost commented May 15, 2015

Copy link
Copy Markdown
Author

I signed it!

Copy link
Copy Markdown

CLAs look good, thanks!

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 15, 2015

dhermes commented May 15, 2015

Copy link
Copy Markdown
Contributor

Looks fine. Any reason why you don't just use the Blob.upload_* methods?

ghost commented May 15, 2015

Copy link
Copy Markdown
Author

not particularly, either works

dhermes commented May 15, 2015

Copy link
Copy Markdown
Contributor

I think we've even debated making Bucket.upload_file a protected method to just encourage people to use the Blob directly.


Can you address the test failure:

TypeError: upload_from_filename() got an unexpected keyword argument 'content_type'

ghost commented May 15, 2015

Copy link
Copy Markdown
Author

hm.. the test passes for me
I'll look into it tomorrow

dhermes commented May 15, 2015

Copy link
Copy Markdown
Contributor

Thanks. You are running the tests locally via tox, yes?

ghost commented May 15, 2015

Copy link
Copy Markdown
Author

yes, I am also using the code in production

dhermes commented May 15, 2015

Copy link
Copy Markdown
Contributor

Notice it's a test fixture _Blob which encounters an unexpected keyword argument 'content_type': https://github.com/GoogleCloudPlatform/gcloud-python/blob/9c4867ab3a26b6f5e19f85c5d66e3c9083a8d83f/gcloud/storage/test_bucket.py#L525-L533

dhermes closed this Aug 6, 2015
parthea pushed a commit that referenced this pull request Aug 21, 2025
* chore(python): fix typo in README

Source-Link: googleapis/synthtool@93e1685
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cd

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Sep 16, 2025
* chore(python): fix typo in README

Source-Link: googleapis/synthtool@93e1685
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:631b4a35a4f9dd5e97740a97c4c117646eb85b35e103844dc49d152bd18694cd

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
parthea pushed a commit that referenced this pull request Sep 18, 2025
Source-Link: googleapis/synthtool@aa69fb7
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f016446d6e520e5fb552c45b110cba3f217bffdd3d06bdddd076e9e6d13266cf

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 24, 2025
Small change to fix bug noticed in googleapis/python-dialogflow#288.

The import was `from google.rpc import status_pb2` but code expected `gr_status`
parthea pushed a commit that referenced this pull request Nov 24, 2025
…mplates/python_library/.kokoro (#883)

Source-Link: googleapis/synthtool@30bd01b
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Nov 26, 2025
parthea pushed a commit that referenced this pull request Feb 13, 2026
PR created by the Librarian CLI to initialize a release. Merging this PR
will auto trigger a release.

Librarian Version: v1.0.1
Language Image:
us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:c8612d3fffb3f6a32353b2d1abd16b61e87811866f7ec9d65b59b02eb452a620
<details><summary>google-api-core: 2.29.0</summary>

##
[2.29.0](googleapis/python-api-core@v2.28.1...v2.29.0)
(2026-01-08)

### Features

* make parse_version_to_tuple public (#864)
([c969186f](googleapis/python-api-core@c969186f))

* Auto enable mTLS when supported certificates are detected (#869)
([f8bf6f96](googleapis/python-api-core@f8bf6f96))

### Bug Fixes

* remove call to importlib.metadata.packages_distributions() for
py38/py39 (#859)
([628003e2](googleapis/python-api-core@628003e2))

* Log version check errors (#858)
([6493118c](googleapis/python-api-core@6493118c))

* flaky tests due to imprecision in floating point calculation and
performance test setup (#865)
([93404080](googleapis/python-api-core@93404080))

* closes tailing streams in bidi classes. (#851)
([c97b3a00](googleapis/python-api-core@c97b3a00))

</details>
parthea pushed a commit that referenced this pull request Mar 6, 2026
Fixed language issues.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

Co-authored-by: pallabiwrites <87546424+pallabiwrites@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Mar 9, 2026
Made changes that override api endpoint information while triggering builds from kokoro .
All tests against prod are still successful.
Some system tests are currently incompatible with nonprod environments and hence are marked to be skipped if endpoint is being overriden.
parthea pushed a commit that referenced this pull request Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL