| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Also - Updated docstrings which don't pass / are invalid. - Integrated plugin with `tox lint` rule and `run_pylint`. For now, pulling directly from the mercurial source repository to get the `check_docs` pylint extension. The maintainter mentioned this will be released July 15-17, 2015. See: http://www.bitbucket.org/logilab/pylint/pull-request/143/
Sorry, something went wrong.
|
@tseaver Sorry about reviewninja. I was toying around with it and didn't realize it had privileges to comment on GitHub. I have now disabled that. |
Sorry, something went wrong.
|
This is kind of an ugly, wide-ranging change to be merging in the middle of other development (it is going to cause conflicts for pretty much any WIP / open PR. |
Sorry, something went wrong.
|
@tseaver I'm with you on most of that (not sure I buy that it's ugly, but some of the diffs are hard to grok). But do we ever foresee a time where we won't be in the middle of development? This likely won't cause merge issues because it touches docstrings whereas most code changes will touch code. Did you have your dataset -> client rename in mind or something else? As for open PRs, it is definitely going to be an issue, but again, one we can't really avoid. As you can see from these changes, we had a lot of docstrings that weren't actually documenting the methods / classes / functions correctly. |
Sorry, something went wrong.
|
@tseaver How do you see a merge going? I assume you finished your review? |
Sorry, something went wrong.
|
If you can stand the merge problems this issue creates, go ahead and merge (I would be tempted to defer this until a "janitorial" phase, myself). |
Sorry, something went wrong.
|
I checked the open PRs (12 - this one = 11) and there is nothing with any real conflict.
|
Sorry, something went wrong.
Adding Pylint plugin to check Sphinx docstrings.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
* fix: remove custom retry loop * removed async implementation * removed unneeded imports --------- Co-authored-by: Kevin Zheng <147537668+gkevinzheng@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
…Metadata (#948) * feat(spanner): add DdlStatementActionInfo and add actions to UpdateDatabaseDdlMetadata PiperOrigin-RevId: 536483675 Source-Link: googleapis/googleapis@9b1c253 Source-Link: googleapis/googleapis-gen@b901406 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjkwMTQwNjQ1ZDRlMWNmYTdiNTZmNjA4M2E0M2NmZGQ4NzI1NThiYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
Also
For now, pulling directly from the mercurial source repository to get the check_docs pylint extension. The maintainer mentioned this will be released July 15-17, 2015.
See:
http://www.bitbucket.org/logilab/pylint/pull-request/143/