FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

docs: add python 2 EOL warning to reference documentation by busunkim96 · Pull Request #9036 · googleapis/google-cloud-python · GitHub

docs: add python 2 EOL warning to reference documentation - #9036

Merged
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:python2-deprecation-docs
Nov 11, 2019
Merged

docs: add python 2 EOL warning to reference documentation#9036
busunkim96 merged 6 commits into
googleapis:masterfrom
busunkim96:python2-deprecation-docs

Conversation

busunkim96 commented Aug 16, 2019
edited
Loading

Copy link
Copy Markdown
Contributor

This PR adds a banner like the one below for all libraries:

busunkim96 added the type: docs Improvement to the documentation for an API. label Aug 16, 2019
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 16, 2019

crwilcox commented Nov 6, 2019

Copy link
Copy Markdown
Contributor

busunkim96 changed the title Docs: Add Python 2 EOL warning to reference documentation. docs: add python 2 EOL warning to reference documentation. Nov 6, 2019

Copy link
Copy Markdown
Contributor Author

Working on getting this added to the enerator

busunkim96 force-pushed the python2-deprecation-docs branch from bcb33c1 to 3af2cff Compare November 9, 2019 00:33
busunkim96 marked this pull request as ready for review November 9, 2019 00:35
busunkim96 requested a review from a team November 9, 2019 00:35

crwilcox left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for batching this up.

Copy link
Copy Markdown
Contributor Author

Asset - system test failure (VPCSC)
BigQuery - system test failure (fixed in #9649)
Resource Manager - needs blackening
Security Center - snippets failure (resource names too long)
Storage - most likely a flake, failed only in 2.7
Trace - system test failure (VPCSC)

busunkim96 changed the title docs: add python 2 EOL warning to reference documentation. docs: add python 2 EOL warning to reference documentation Nov 11, 2019

tseaver commented Nov 11, 2019

Copy link
Copy Markdown
Contributor

The current storage failure is an actual buggy unit test (query string parameter ordering):

E   Expected: request(data=<ANY>, headers=<ANY>, method='POST', url='https://storage.googleapis.com/storage/v1/b?project=OTHER_PROJECT&userProject=USER_PROJECT')
E   Actual: request(data='{"name": "bucket-name"}', headers={'Content-Type': 'application/json', 'X-Goog-API-Client': 'gcloud-python/1.22.0  gl-python/3.5.3 gax/1.14.3 gccl/1.22.0', 'User-Agent': 'gcloud-python/1.22.0  gl-python/3.5.3 gax/1.14.3 gccl/1.22.0', 'Accept-Encoding': 'gzip'}, method='POST', url='https://storage.googleapis.com/storage/v1/b?userProject=USER_PROJECT&project=OTHER_PROJECT')

Reported as #9714.

busunkim96 added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL