FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore(bigquery): fix undelete table system test to use milliseconds in snapshot decorator by tswast · Pull Request #9649 · googleapis/google-cloud-python · GitHub

chore(bigquery): fix undelete table system test to use milliseconds in snapshot decorator - #9649

Merged
tswast merged 1 commit into
googleapis:masterfrom
tswast:issue9633-undelete
Nov 9, 2019
Merged

chore(bigquery): fix undelete table system test to use milliseconds in snapshot decorator#9649
tswast merged 1 commit into
googleapis:masterfrom
tswast:issue9633-undelete

Conversation

tswast commented Nov 8, 2019

Copy link
Copy Markdown
Contributor

This fixes a flakey system test, where sometimes we sent an invalid
timestamp as a snapshot to copy from.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #9633

…n snapshot decorator

This fixes a flakey system test, where sometimes we sent an invalid
timestamp as a snapshot to copy from.
tswast requested a review from a team November 8, 2019 23:39
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2019
tswast requested a review from busunkim96 November 8, 2019 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BigQuery: 'test_undelete_table' fails with 500

3 participants


Back | FazBrowse Home | New Git URL