FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(samples): add create-featurestore sample by sai-chaithu · Pull Request #948 · googleapis/java-aiplatform · GitHub

This repository was archived by the owner on Sep 9, 2023. It is now read-only.
/ java-aiplatform Public archive

feat(samples): add create-featurestore sample - #948

Merged
diemtvu merged 8 commits into
googleapis:mainfrom
sai-chaithu:main
Jun 21, 2022
Merged

feat(samples): add create-featurestore sample#948
diemtvu merged 8 commits into
googleapis:mainfrom
sai-chaithu:main

Conversation

sai-chaithu commented Jun 10, 2022
edited by diemtvu
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

#945

snippet-bot Bot commented Jun 10, 2022
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

product-auto-label Bot added size: l Pull request size is large. api: vertex-ai Issues related to the googleapis/java-aiplatform API. labels Jun 10, 2022
sai-chaithu changed the title Create Featurestore Sample API Code Snippet feat(samples): add create-featurestore sample Jun 10, 2022
int maxNodeCount = 5;
String location = "us-central1";
String endpoint = "us-central1-aiplatform.googleapis.com:443";
int timeout = 900;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Pls change this 15 minutes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The timeout unit is kept in seconds so I have given 900 which is equal to 15 minutes, Should I change the timeout unit to minutes??

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ah, sorry my math. lgtm

diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2022
diemtvu self-assigned this Jun 11, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 11, 2022
product-auto-label Bot added the samples Issues that are directly related to samples. label Jun 11, 2022

diemtvu commented Jun 14, 2022

Copy link
Copy Markdown

Please move new changes to a new PR. Let's keep this PR small so to make sure all reviews are done properly. Thanks

diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 16, 2022
diemtvu previously approved these changes Jun 16, 2022
diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2022
diemtvu added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 18, 2022

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 18, 2022
diemtvu added owlbot:run Add this label to trigger the Owlbot post processor. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Jun 20, 2022
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 20, 2022
sai-chaithu requested review from a team June 20, 2022 18:32
gcf-merge-on-green Bot dismissed diemtvu’s stale review June 20, 2022 18:32

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 21, 2022
diemtvu added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2022
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 21, 2022
diemtvu added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 21, 2022

Copy link
Copy Markdown

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 21, 2022
diemtvu merged commit ac7ca36 into googleapis:main Jun 21, 2022
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jul 1, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.0](v2.9.8...v3.0.0) (2022-07-01)


### ⚠ BREAKING CHANGES

* added packaging options for C#, Ruby, and PHP

### Features

* add BatchImportModelEvaluationSlices API in aiplatform v1 model_service.proto ([#972](#972)) ([3041b97](3041b97))
* add BatchImportModelEvaluationSlices API in aiplatform v1beta1 model_service.proto ([3041b97](3041b97))
* add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([0ae5d15](0ae5d15))
* add ListSavedQueries rpc to aiplatform v1 dataset_service.proto ([#975](#975)) ([85be17b](85be17b))
* add ListSavedQueries rpc to aiplatform v1beta1 dataset_service.proto ([85be17b](85be17b))
* add model_monitoring_config to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#892](#892)) ([0ae5d15](0ae5d15))
* add model_version_id to BatchPredictionJob in aiplatform v1 batch_prediction_job.proto ([3041b97](3041b97))
* add model_version_id to DeployedModel in aiplatform v1 endpoint.proto ([3041b97](3041b97))
* add model_version_id to PredictResponse in aiplatform v1 prediction_service.proto ([3041b97](3041b97))
* add saved_query_id to InputDataConfig in aiplatform v1 training_pipeline.proto ([85be17b](85be17b))
* add saved_query_id to InputDataConfig in aiplatform v1beta1 training_pipeline.proto ([85be17b](85be17b))
* add saved_query.proto to aiplatform v1 ([85be17b](85be17b))
* add saved_query.proto to aiplatform v1beta1 ([85be17b](85be17b))
* add template_metadata to PipelineJob in aiplatform v1beta1 pipeline_job.proto ([0ae5d15](0ae5d15))
* **samples:** add create-featurestore sample ([#948](#948)) ([ac7ca36](ac7ca36))


### Bug Fixes

* added packaging options for C#, Ruby, and PHP ([0ae5d15](0ae5d15))
* update gapic-generator-java with mock service generation fixes ([#979](#979)) ([745b9cd](745b9cd))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#973](#973)) ([87b311d](87b311d))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions Bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jul 1, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.0](googleapis/java-aiplatform@v2.9.8...v3.0.0) (2022-07-01)


### ⚠ BREAKING CHANGES

* added packaging options for C#, Ruby, and PHP

### Features

* add BatchImportModelEvaluationSlices API in aiplatform v1 model_service.proto ([googleapis#972](googleapis/java-aiplatform#972)) ([7f45b24](googleapis/java-aiplatform@7f45b24))
* add BatchImportModelEvaluationSlices API in aiplatform v1beta1 model_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))
* add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([a2a404f](googleapis/java-aiplatform@a2a404f))
* add ListSavedQueries rpc to aiplatform v1 dataset_service.proto ([googleapis#975](googleapis/java-aiplatform#975)) ([ab9ba69](googleapis/java-aiplatform@ab9ba69))
* add ListSavedQueries rpc to aiplatform v1beta1 dataset_service.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69))
* add model_monitoring_config to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([googleapis#892](googleapis/java-aiplatform#892)) ([a2a404f](googleapis/java-aiplatform@a2a404f))
* add model_version_id to BatchPredictionJob in aiplatform v1 batch_prediction_job.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))
* add model_version_id to DeployedModel in aiplatform v1 endpoint.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))
* add model_version_id to PredictResponse in aiplatform v1 prediction_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))
* add saved_query_id to InputDataConfig in aiplatform v1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69))
* add saved_query_id to InputDataConfig in aiplatform v1beta1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69))
* add saved_query.proto to aiplatform v1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69))
* add saved_query.proto to aiplatform v1beta1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69))
* add template_metadata to PipelineJob in aiplatform v1beta1 pipeline_job.proto ([a2a404f](googleapis/java-aiplatform@a2a404f))
* **samples:** add create-featurestore sample ([googleapis#948](googleapis/java-aiplatform#948)) ([ffc4b87](googleapis/java-aiplatform@ffc4b87))


### Bug Fixes

* added packaging options for C#, Ruby, and PHP ([a2a404f](googleapis/java-aiplatform@a2a404f))
* update gapic-generator-java with mock service generation fixes ([googleapis#979](googleapis/java-aiplatform#979)) ([e5f3ca5](googleapis/java-aiplatform@e5f3ca5))


### Dependencies

* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#973](googleapis/java-aiplatform#973)) ([56ad705](googleapis/java-aiplatform@56ad705))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: vertex-ai Issues related to the googleapis/java-aiplatform API. samples Issues that are directly related to samples. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL