Chain cause in ComputeException.translateAndThrow, add tests by mziccard · Pull Request #948 · googleapis/google-cloud-java · GitHub

This fixes #946 for the compute module

Changes Unknown when pulling b0446ba on mziccard:compute-add-cause into * on GoogleCloudPlatform:compute-alpha*.

LGTM

@aozarov I just noticed that we do very have different access modifiers for exceptions' constructors. In dns they are private while in other services they're public. I suggest we make the package scoped for the sake of testing. What do you think?

Yes, I think consistency here is good and package scope would be a good choice.

Changes Unknown when pulling 678f049 on mziccard:compute-add-cause into * on GoogleCloudPlatform:compute-alpha*.

…pis#948) Chain cause in ComputeException.translateAndThrow, add tests and make ComputeException constructors package scoped.

* CreateFeaturestore Sample API * DeleteFeaturestore Sample API * Create, Update, Get featurestore API's * Revert Code * CreateFeaturestoreSampleTest update * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [4.7.0](googleapis/java-dialogflow@v4.6.0...v4.7.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#941](googleapis/java-dialogflow#941)) ([a1d1971](googleapis/java-dialogflow@a1d1971)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#943](googleapis/java-dialogflow#943)) ([5ea0c35](googleapis/java-dialogflow@5ea0c35)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.0 ([googleapis#939](googleapis/java-dialogflow#939)) ([a199fd4](googleapis/java-dialogflow@a199fd4)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#940](googleapis/java-dialogflow#940)) ([3da152f](googleapis/java-dialogflow@3da152f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.0.0](googleapis/java-aiplatform@v2.9.8...v3.0.0) (2022-07-01) ### ⚠ BREAKING CHANGES * added packaging options for C#, Ruby, and PHP ### Features * add BatchImportModelEvaluationSlices API in aiplatform v1 model_service.proto ([googleapis#972](googleapis/java-aiplatform#972)) ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add BatchImportModelEvaluationSlices API in aiplatform v1beta1 model_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([a2a404f](googleapis/java-aiplatform@a2a404f)) * add ListSavedQueries rpc to aiplatform v1 dataset_service.proto ([googleapis#975](googleapis/java-aiplatform#975)) ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add ListSavedQueries rpc to aiplatform v1beta1 dataset_service.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add model_monitoring_config to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([googleapis#892](googleapis/java-aiplatform#892)) ([a2a404f](googleapis/java-aiplatform@a2a404f)) * add model_version_id to BatchPredictionJob in aiplatform v1 batch_prediction_job.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add model_version_id to DeployedModel in aiplatform v1 endpoint.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add model_version_id to PredictResponse in aiplatform v1 prediction_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24)) * add saved_query_id to InputDataConfig in aiplatform v1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add saved_query_id to InputDataConfig in aiplatform v1beta1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add saved_query.proto to aiplatform v1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add saved_query.proto to aiplatform v1beta1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69)) * add template_metadata to PipelineJob in aiplatform v1beta1 pipeline_job.proto ([a2a404f](googleapis/java-aiplatform@a2a404f)) * **samples:** add create-featurestore sample ([googleapis#948](googleapis/java-aiplatform#948)) ([ffc4b87](googleapis/java-aiplatform@ffc4b87)) ### Bug Fixes * added packaging options for C#, Ruby, and PHP ([a2a404f](googleapis/java-aiplatform@a2a404f)) * update gapic-generator-java with mock service generation fixes ([googleapis#979](googleapis/java-aiplatform#979)) ([e5f3ca5](googleapis/java-aiplatform@e5f3ca5)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#973](googleapis/java-aiplatform#973)) ([56ad705](googleapis/java-aiplatform@56ad705)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.6.4](googleapis/java-dlp@v3.6.3...v3.6.4) (2022-08-02) ### Dependencies * update dependency com.google.cloud:google-cloud-pubsub to v1.120.5 ([#943](googleapis/java-dlp#943)) ([4c7b002](googleapis/java-dlp@4c7b002)) * update dependency com.google.cloud:google-cloud-pubsub to v1.120.8 ([#947](googleapis/java-dlp#947)) ([b66f7b1](googleapis/java-dlp@b66f7b1)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#946](googleapis/java-dlp#946)) ([9344629](googleapis/java-dlp@9344629)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

#948) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 485623855 Source-Link: https://togithub.com/googleapis/googleapis/commit/807125e7953e32535710924fe4bf0362ac93754d Source-Link: https://togithub.com/googleapis/googleapis-gen/commit/c4ddd6d651da69658a4762c5eafff5cd8f0e25c5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzRkZGQ2ZDY1MWRhNjk2NThhNDc2MmM1ZWFmZmY1Y2Q4ZjBlMjVjNSJ9

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [google-auth](https://togithub.com/googleapis/google-auth-library-python) | `==2.11.0` -> `==2.12.0` | [![age](https://badges.renovateapi.com/packages/pypi/google-auth/2.12.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/google-auth/2.12.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/google-auth/2.12.0/compatibility-slim/2.11.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/google-auth/2.12.0/confidence-slim/2.11.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

…948) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.protobuf:protobuf-bom](https://developers.google.com/protocol-buffers/) ([source](https://togithub.com/protocolbuffers/protobuf)) | `3.21.10` -> `3.21.12` | [![age](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.12/compatibility-slim/3.21.10)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.protobuf:protobuf-bom/3.21.12/confidence-slim/3.21.10)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>protocolbuffers/protobuf</summary> ### [`v3.21.12`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.11...v3.21.12) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.11...v3.21.12) ### [`v3.21.11`](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.10...v3.21.11) [Compare Source](https://togithub.com/protocolbuffers/protobuf/compare/v3.21.10...v3.21.11) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-shared-dependencies).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…e to v2.13.1 (#948) * chore(deps): update dependency com.google.cloud:google-cloud-datastore to v2.13.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [0.124.8](googleapis/java-storage-nio@v0.124.7...v0.124.8) (2022-07-11) ### Dependencies * update dependency com.google.apis:google-api-services-storage to v1-rev20220705-1.32.1 ([#946](googleapis/java-storage-nio#946)) ([479b621](googleapis/java-storage-nio@479b621)) * update dependency com.google.cloud:google-cloud-storage to v2.9.3 ([#945](googleapis/java-storage-nio#945)) ([57fcc40](googleapis/java-storage-nio@57fcc40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.0 (#948) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `24.0.0` -> `24.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/compatibility-slim/24.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.1.0/confidence-slim/24.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).

…cies to v2.0.1 (googleapis#948) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-dependencies](https://togithub.com/googleapis/java-shared-dependencies) | `2.0.0` -> `2.0.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/compatibility-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-dependencies/2.0.1/confidence-slim/2.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-dependencies</summary> ### [`v2.0.1`](https://togithub.com/googleapis/java-shared-dependencies/blob/master/CHANGELOG.md#201-httpswwwgithubcomgoogleapisjava-shared-dependenciescompare200v201-2021-08-11) [Compare Source](https://togithub.com/googleapis/java-shared-dependencies/compare/v2.0.0...v2.0.1) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-bigtable).

Chain cause in ComputeException.translateAndThrow, add tests

b0446ba

mziccard added the api: compute Issues related to the Compute Engine API. label Apr 20, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 20, 2016

aozarov reviewed Apr 20, 2016
View reviewed changes

Comment thread gcloud-java-compute/src/test/java/com/google/gcloud/compute/ComputeExceptionTest.java Outdated

assertEquals("message", ex.getMessage());

assertFalse(ex.retryable());

assertTrue(ex.idempotent());

assertEquals(cause, ex.getCause());

This comment was marked as spam.

Sign in to view

Make ComputeException constructors package scoped, better test coverage

678f049

aozarov merged commit 2643243 into googleapis:compute-alpha Apr 20, 2016

meltsufin pushed a commit that referenced this pull request Dec 22, 2025

chore(main): release 3.7.6 (#948 )

4c33e8b

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

chore(main): release 0.128.5 (#948 )

afd6add

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

suztomo pushed a commit to suztomo/google-cloud-java that referenced this pull request Mar 11, 2026

chore(main): release 3.7.6 (googleapis#948 )

8ec2722

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Chain cause in ComputeException.translateAndThrow, add tests by mziccard · Pull Request #948 · googleapis/google-cloud-java · GitHub

Uh oh!

Chain cause in ComputeException.translateAndThrow, add tests - #948

Chain cause in ComputeException.translateAndThrow, add tests#948
aozarov merged 2 commits into
googleapis:compute-alphafrom
mziccard:compute-add-cause

mziccard commented Apr 20, 2016

Uh oh!

coveralls commented Apr 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 20, 2016

Uh oh!

mziccard commented Apr 20, 2016

Uh oh!

aozarov commented Apr 20, 2016

Uh oh!

coveralls commented Apr 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

+                    assertEquals("message", ex.getMessage());
+                    assertFalse(ex.retryable());
+                    assertTrue(ex.idempotent());
+                    assertEquals(cause, ex.getCause());

Chain cause in ComputeException.translateAndThrow, add tests by mziccard · Pull Request #948 · googleapis/google-cloud-java · GitHub

Uh oh!

Chain cause in ComputeException.translateAndThrow, add tests - #948

Chain cause in ComputeException.translateAndThrow, add tests#948aozarov merged 2 commits intogoogleapis:compute-alphagoogleapis/google-cloud-java:compute-alphafrom mziccard:compute-add-causemziccard/gcloud-java:compute-add-causeCopy head branch name to clipboard

Conversation

mziccard commented Apr 20, 2016

Uh oh!

coveralls commented Apr 20, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 20, 2016

Uh oh!

mziccard commented Apr 20, 2016

Uh oh!

aozarov commented Apr 20, 2016

Uh oh!

coveralls commented Apr 20, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Chain cause in ComputeException.translateAndThrow, add tests#948
aozarov merged 2 commits into
googleapis:compute-alphafrom
mziccard:compute-add-cause