Move Clock out of ServiceOptions, use it in RetryHelper by mziccard · Pull Request #954 · googleapis/google-cloud-java · GitHub

This fixes #950. This also moves Clock out of ServiceOptions as it makes more sense since it's shared with RetryHelper.

Coverage increased (+0.02%) to 85.757% when pulling 329ab44 on mziccard:retry-helper-clock into 0a6c6f7 on GoogleCloudPlatform:master.

Looks great. Next we need to use that Clock in all our RetryHelper usages (and make runWithRetries with Clock public).

Before merging this we should make:

runWithRetries(Callable<V> callable, RetryParams params, ExceptionHandler exceptionHandler, Clock clock)

public and use it across all services passing the clock contained in ServiceOptions.

Coverage increased (+0.007%) to 85.982% when pulling 497ccbd on mziccard:retry-helper-clock into d5cf726 on GoogleCloudPlatform:master.

Rebased to get compute's module. Added 497ccbd to pass options.clock() to retryHelper.runWithRetries everywhere we use it.

…form-v1beta1 to v0.15.7 (#954) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1](https://togithub.com/googleapis/java-) | `0.15.6` -> `0.15.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.15.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.15.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.15.7/compatibility-slim/0.15.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1/0.15.7/confidence-slim/0.15.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).

🤖 I have created a release *beep* *boop* --- ## [2.9.8](googleapis/java-aiplatform@v2.9.7...v2.9.8) (2022-06-21) ### Dependencies * update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.15.7 ([#954](googleapis/java-aiplatform#954)) ([3a7848a](googleapis/java-aiplatform@3a7848a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…3.6.5 (#954) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-dlp](https://togithub.com/googleapis/java-dlp) | `3.6.4` -> `3.6.5` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dlp/3.6.5/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dlp/3.6.5/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dlp/3.6.5/compatibility-slim/3.6.4)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-dlp/3.6.5/confidence-slim/3.6.4)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp).

…1.1 (#954) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-storage](https://togithub.com/googleapis/java-storage) | `2.11.0` -> `2.11.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/compatibility-slim/2.11.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/confidence-slim/2.11.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

…tectIntentRequest's text input is limited by 256 characters (#954) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 463362184 Source-Link: googleapis/googleapis@1805fc2 Source-Link: https://github.com/googleapis/googleapis-gen/commit/c47083a7b829c85e3423250f7cf431f07238ad04 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYzQ3MDgzYTdiODI5Yzg1ZTM0MjMyNTBmN2NmNDMxZjA3MjM4YWQwNCJ9 docs: added an explicit note that DetectIntentRequest's text input is limited by 256 characters PiperOrigin-RevId: 463252698 Source-Link: googleapis/googleapis@eeacaab Source-Link: https://github.com/googleapis/googleapis-gen/commit/da3bfa08ba77d14ba66e6eeee5ad159ef365df0f Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZGEzYmZhMDhiYTc3ZDE0YmE2NmU2ZWVlZTVhZDE1OWVmMzY1ZGYwZiJ9 chore(bazel): update protobuf to v3.21.3 chore(bazel): update gax-java to 2.18.4 PiperOrigin-RevId: 463115700 Source-Link: googleapis/googleapis@52130a9 Source-Link: https://github.com/googleapis/googleapis-gen/commit/6a4d9d9bb3afb20b0f5fa4f5d9f6740b1d0eb19a Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNmE0ZDlkOWJiM2FmYjIwYjBmNWZhNGY1ZDlmNjc0MGIxZDBlYjE5YSJ9 feat: provide new parameter cx_current_page, the unique identifier of the CX page to override the `current_page` in the session. Add filter field to ListAnswerRecordsRequest. And add AudioInput to analysis requests docs: add more meaningful comments PiperOrigin-RevId: 459325028 Source-Link: googleapis/googleapis@a076084 Source-Link: https://github.com/googleapis/googleapis-gen/commit/278f4fdb4a4ef5ff68da3f40f30367ca3e1717bf Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjc4ZjRmZGI0YTRlZjVmZjY4ZGEzZjQwZjMwMzY3Y2EzZTE3MTdiZiJ9 feat: deprecated the filter field and add resource_definition docs: add more meaningful comments PiperOrigin-RevId: 458520697 Source-Link: googleapis/googleapis@2bf9d8d Source-Link: https://github.com/googleapis/googleapis-gen/commit/ce2a70aadab1593d6daf8609e5fdd0cf0c644bbc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2UyYTcwYWFkYWIxNTkzZDZkYWY4NjA5ZTVmZGQwY2YwYzY0NGJiYyJ9

🤖 I have created a release *beep* *boop* --- ## [4.8.0](googleapis/java-dialogflow@v4.7.5...v4.8.0) (2022-08-05) ### Features * deprecated the filter field and add resource_definition ([d58232f](googleapis/java-dialogflow@d58232f)) * provide new parameter cx_current_page, the unique identifier of the CX page to override the `current_page` in the session. Add filter field to ListAnswerRecordsRequest. And add AudioInput to analysis requests ([d58232f](googleapis/java-dialogflow@d58232f)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#979](googleapis/java-dialogflow#979)) ([aee2eab](googleapis/java-dialogflow@aee2eab)) ### Documentation * add more meaningful comments ([d58232f](googleapis/java-dialogflow@d58232f)) * add more meaningful comments ([d58232f](googleapis/java-dialogflow@d58232f)) * added an explicit note that DetectIntentRequest's text input is limited by 256 characters ([d58232f](googleapis/java-dialogflow@d58232f)) * **owlbot-java:** explaining why not using formatter in pom.xml ([#1511](https://github.com/googleapis/java-dialogflow/issues/1511)) ([#973](googleapis/java-dialogflow#973)) ([3202efe](googleapis/java-dialogflow@3202efe)), closes [#1502](https://github.com/googleapis/java-dialogflow/issues/1502) * updated some method comments and added an explicit note that DetectIntentRequest's text input is limited by 256 characters ([#954](googleapis/java-dialogflow#954)) ([d58232f](googleapis/java-dialogflow@d58232f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [protobuf](https://developers.google.com/protocol-buffers/) | `==3.19.5` -> `==3.20.2` | [![age](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/compatibility-slim/3.19.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/protobuf/3.20.2/confidence-slim/3.19.5)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…s#1687) (googleapis#954) * chore(java): add a note in README for migrated split repos Disable renovate bot and flaky bot for split repositories that have moved to the Java monorepo. The Java monorepo will pass the "monorepo=True" parameter to java.common_templates method in its owlbot.py files so that the migration note will not appear in the README in the monorepo. Co-authored-by: Jeff Ching <chingor@google.com> Source-Link: https://togithub.com/googleapis/synthtool/commit/d4b291604f148cde065838c498bc8aa79b8dc10e Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:edae91ccdd2dded2f572ec341a768ad180305a3e8fbfd93064b28e237d35920a

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [keyring](https://togithub.com/jaraco/keyring) | `==23.4.1` -> `==23.9.3` | [![age](https://badges.renovateapi.com/packages/pypi/keyring/23.9.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/keyring/23.9.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/keyring/23.9.3/compatibility-slim/23.4.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/keyring/23.9.3/confidence-slim/23.4.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…3.6 (#954)

…9.2 (#954)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.junit:junit-bom](https://junit.org/junit5/) ([source](https://togithub.com/junit-team/junit5)) | `5.8.2` -> `5.9.0` | [![age](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/compatibility-slim/5.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/confidence-slim/5.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.junit:junit-bom](https://junit.org/junit5/) ([source](https://togithub.com/junit-team/junit5)) | `5.8.2` -> `5.9.0` | [![age](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/compatibility-slim/5.8.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.junit:junit-bom/5.9.0/confidence-slim/5.8.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/google-auth-library-java).

…19.2 (#954) * deps: update dependency com.google.protobuf:protobuf-java-util to v3.19.2 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-08-16 14:04:14,912 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigtable/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-08-16 14:04:16,176 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/7d8b8f8c-b573-4754-a8c1-e11dc50691ef/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

mziccard added the api: core label Apr 22, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2016

mziccard added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 22, 2016

mziccard added 2 commits May 18, 2016 20:01

Move Clock out of ServiceOptions, use it in RetryHelper

d1ab2bd

Always pass options.clock() to RetryHelper.runWithRetries

497ccbd

mziccard force-pushed the retry-helper-clock branch from 329ab44 to 497ccbd Compare May 18, 2016 20:02

mziccard removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 18, 2016

mziccard merged commit 4c0332e into googleapis:master May 20, 2016

This was referenced Nov 13, 2024

chore: Update generation configuration at Fri Nov 15 02:26:49 UTC 2024 #11284

Closed

chore: Update generation configuration at Fri Nov 15 18:28:33 UTC 2024 #11307

Merged

release-please Bot mentioned this pull request Nov 15, 2024

chore(main): release 1.48.0 #11283

Merged

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

deps: update dependency com.google.cloud:google-cloud-logging to v3.1…

b1bc20f

…3.6 (#954)

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

deps: update dependency org.junit.vintage:junit-vintage-engine to v5.…

b0b72bb

…9.2 (#954)

Move Clock out of ServiceOptions, use it in RetryHelper by mziccard · Pull Request #954 · googleapis/google-cloud-java · GitHub

Uh oh!

Move Clock out of ServiceOptions, use it in RetryHelper - #954

Move Clock out of ServiceOptions, use it in RetryHelper#954
mziccard merged 2 commits into
googleapis:masterfrom
mziccard:retry-helper-clock

mziccard commented Apr 22, 2016

Uh oh!

coveralls commented Apr 22, 2016

Uh oh!

aozarov commented Apr 22, 2016

Uh oh!

mziccard commented Apr 22, 2016

Uh oh!

coveralls commented May 18, 2016

Uh oh!

mziccard commented May 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Move Clock out of ServiceOptions, use it in RetryHelper by mziccard · Pull Request #954 · googleapis/google-cloud-java · GitHub

Uh oh!

Move Clock out of ServiceOptions, use it in RetryHelper - #954

Move Clock out of ServiceOptions, use it in RetryHelper#954mziccard merged 2 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom mziccard:retry-helper-clockmziccard/gcloud-java:retry-helper-clockCopy head branch name to clipboard

Conversation

mziccard commented Apr 22, 2016

Uh oh!

coveralls commented Apr 22, 2016

Uh oh!

aozarov commented Apr 22, 2016

Uh oh!

mziccard commented Apr 22, 2016

Uh oh!

coveralls commented May 18, 2016

Uh oh!

mziccard commented May 18, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Move Clock out of ServiceOptions, use it in RetryHelper#954
mziccard merged 2 commits into
googleapis:masterfrom
mziccard:retry-helper-clock