Make DNS batch get zone/changerequest return null for NOT_FOUND by mziccard · Pull Request #953 · googleapis/google-cloud-java · GitHub

This fixes #949: DnsBatch.getZone and DnsBatch.getChangeRequest now return null for NOT_FOUND. This PR also adds more tests.

Coverage decreased (-0.006%) to 85.731% when pulling dfbfeeb on mziccard:fix-dns-batch into 0a6c6f7 on GoogleCloudPlatform:master.

LGTM

Coverage decreased (-0.001%) to 85.736% when pulling 7d9f33d on mziccard:fix-dns-batch into 0a6c6f7 on GoogleCloudPlatform:master.

…rm to v2.9.7 (#953) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-aiplatform](https://togithub.com/googleapis/java-) | `2.9.6` -> `2.9.7` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/compatibility-slim/2.9.6)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/2.9.7/confidence-slim/2.9.6)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…953) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.7` -> `2.8.8` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/compatibility-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.8/confidence-slim/2.8.7)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.8`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#288-httpsgithubcomgoogleapisjava-corecomparev287v288-2022-08-04) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.7...v2.8.8) ##### Dependencies - update dependency com.google.errorprone:error_prone_annotations to v2.15.0 ([#897](https://togithub.com/googleapis/java-core/issues/897)) ([29e4fc9](https://togithub.com/googleapis/java-core/commit/29e4fc93d5d4d50f7de85eae7a8150314cca6f43)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [markupsafe](https://palletsprojects.com/p/markupsafe/) ([changelog](https://markupsafe.palletsprojects.com/changes/)) | `==2.0.1` -> `==2.1.1` | [![age](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/compatibility-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/markupsafe/2.1.1/confidence-slim/2.0.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-monitoring).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [jinja2](https://palletsprojects.com/p/jinja/) ([changelog](https://jinja.palletsprojects.com/changes/)) | `==3.0.3` -> `==3.1.2` | [![age](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/compatibility-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/jinja2/3.1.2/confidence-slim/3.0.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…cies to v3.1.1 (#953)

Source-Link: googleapis/synthtool@48f8857 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:b47e411068ffc6e6990cb4e0802fbac9a4488dec7f5f424553518ba21abea208

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…onfig to v1.2.4 (#953) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.2.2` -> `1.2.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/compatibility-slim/1.2.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.2.4/confidence-slim/1.2.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-shared-config</summary> ### [`v1.2.4`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#124-httpswwwgithubcomgoogleapisjava-shared-configcomparev123v124-2022-01-06) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.3...v1.2.4) ### [`v1.2.3`](https://togithub.com/googleapis/java-shared-config/blob/HEAD/CHANGELOG.md#123-httpswwwgithubcomgoogleapisjava-shared-configcomparev122v123-2022-01-04) [Compare Source](https://togithub.com/googleapis/java-shared-config/compare/v1.2.2...v1.2.3) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).

This PR was generated using Autosynth. 🌈 <details><summary>Log from Synthtool</summary> ``` 2021-08-16 13:48:24,791 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-bigtable/.github/readme/synth.py. On branch autosynth-readme nothing to commit, working tree clean 2021-08-16 13:48:26,651 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata. ``` </details> Full log will be available here: https://source.cloud.google.com/results/invocations/ec52bc52-719d-4ea0-a5ce-b879a2128f67/targets - [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)

mziccard added the api: dns Issues related to the Cloud DNS API. label Apr 22, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 22, 2016

mziccard force-pushed the fix-dns-batch branch from a5e83e5 to dfbfeeb Compare April 22, 2016 12:53

aozarov reviewed Apr 22, 2016
View reviewed changes

Comment thread gcloud-java-dns/src/main/java/com/google/cloud/dns/spi/DefaultDnsRpc.java Outdated

return null;

}

// the zone does not exist, so throw an exception

if (serviceException.code() == HTTP_NOT_FOUND

This comment was marked as spam.

Sign in to view

Make DNS batch get zone/changerequest return null for NOT_FOUND

7d9f33d

mziccard force-pushed the fix-dns-batch branch from dfbfeeb to 7d9f33d Compare April 22, 2016 18:36

mziccard merged commit 121783a into googleapis:master Apr 22, 2016

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency io.grpc:grpc-bom to v1.51.1 (#953 )

35a98fe

chingor13 pushed a commit that referenced this pull request Jan 6, 2026

chore(main): release 0.128.6 (#953 )

258e4e5

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Jan 22, 2026

deps: update dependency com.google.cloud:google-cloud-shared-dependen…

fdffe1e

…cies to v3.1.1 (#953)

suztomo pushed a commit that referenced this pull request Mar 30, 2026

chore(main): release 0.124.10-SNAPSHOT (#953 )

75da2f3

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

lqiu96 pushed a commit that referenced this pull request Apr 1, 2026

chore(main): release 0.124.10-SNAPSHOT (#953 )

b66e56f

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Make DNS batch get zone/changerequest return null for NOT_FOUND by mziccard · Pull Request #953 · googleapis/google-cloud-java · GitHub

Uh oh!

Make DNS batch get zone/changerequest return null for NOT_FOUND - #953

Make DNS batch get zone/changerequest return null for NOT_FOUND#953
mziccard merged 1 commit into
googleapis:masterfrom
mziccard:fix-dns-batch

mziccard commented Apr 22, 2016

Uh oh!

coveralls commented Apr 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 22, 2016

Uh oh!

coveralls commented Apr 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

-                        return null;
-                      }
-                      // the zone does not exist, so throw an exception
+                    if (serviceException.code() == HTTP_NOT_FOUND

Make DNS batch get zone/changerequest return null for NOT_FOUND by mziccard · Pull Request #953 · googleapis/google-cloud-java · GitHub

Uh oh!

Make DNS batch get zone/changerequest return null for NOT_FOUND - #953

Make DNS batch get zone/changerequest return null for NOT_FOUND#953mziccard merged 1 commit intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom mziccard:fix-dns-batchmziccard/gcloud-java:fix-dns-batchCopy head branch name to clipboard

Conversation

mziccard commented Apr 22, 2016

Uh oh!

coveralls commented Apr 22, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Apr 22, 2016

Uh oh!

coveralls commented Apr 22, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Make DNS batch get zone/changerequest return null for NOT_FOUND#953
mziccard merged 1 commit into
googleapis:masterfrom
mziccard:fix-dns-batch