Add support for batches to DNS by mziccard · Pull Request #940 · googleapis/google-cloud-java · GitHub

This PR takes our dns-alpha-batch branch, rebases it on top of master ad applies some necessary rebase-related adjustments.

Major adjustments are:

Add DnsException(GoogleJsonError error, boolean idempotent) constructor to DnsException
Set exception's idempotent field in RpcBatch.Callback, see here for an example
Add tests for idempotent being correctly set by batches
Fix the type of the result parameter in DnsBatch.createXXXCallback() to avoid rawtypes warning. See here for an example

The discussion on batches can be found at #787

* Added third concept of DNS batch. * Simplified the internals. Removed DnsBatch.Request. * Work in progress. Implemented more calls and added tests. * Turned BatchResult into an abstract class. * Created RpcBatch interface for opacity of batch. Added core unit test for BatchResult. Added javadoc for BatchResult generics. Changed prefix of newCallback methods. Fixed method javadoc. * Fixed documentation. * Removed addToBatch methods from RPC. * Removed conflicts with master branch. * Implemented batch processing for change requests and record sets. * Implemented the rest of the batch functions and tests. - Renames several forgotten DnsRecord variables and functions in tests - Moved the Callback interface from DnsRpc to RpcBatch * Added tests for callbacks. Fixed documentation. * Added onFailure callback tests and fixed one doc string. * Extracted GoogleJsonError to a final attribute. * Fixed imports and implemented notify. * Fixed import orders * Annotated getters as @VisibleForTesting. * Fixed docs and renamed a few methods. Also consolidated mocks batch in tests. * Added notify test * Renamed submitted() to completed(). * Consolidated more tests and added exception to notify. * Added test for null result in BatchResult.

* Integration test for batch. Fixes googleapis#874. * Adjusted batch calls in integration tests. * Removed unnecessary copying. * Removed unused import. * Replaced change IDs equals tests with not null.

Added batch support to the local DNS helper

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

Coverage increased (+0.04%) to 85.709% when pulling 2995240 on mziccard:dns-alpha-batch into 5e0de55 on GoogleCloudPlatform:master.

🤖 I have created a release *beep* *boop* --- ## [4.7.0](googleapis/java-dialogflow@v4.6.0...v4.7.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([googleapis#941](googleapis/java-dialogflow#941)) ([a1d1971](googleapis/java-dialogflow@a1d1971)) ### Bug Fixes * update gapic-generator-java with mock service generation fixes ([googleapis#943](googleapis/java-dialogflow#943)) ([5ea0c35](googleapis/java-dialogflow@5ea0c35)) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.0 ([googleapis#939](googleapis/java-dialogflow#939)) ([a199fd4](googleapis/java-dialogflow@a199fd4)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#940](googleapis/java-dialogflow#940)) ([3da152f](googleapis/java-dialogflow@3da152f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [3.0.1](googleapis/java-vision@v3.0.0...v3.0.1) (2022-07-01) ### Dependencies * update dependency com.google.cloud:google-cloud-core to v2.8.1 ([googleapis#931](googleapis/java-vision#931)) ([027e196](googleapis/java-vision@027e196)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.0 (#940) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-video-intelligence).

🤖 I have created a release *beep* *boop* --- ## [3.6.3](googleapis/java-dlp@v3.6.2...v3.6.3) (2022-07-30) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#940](googleapis/java-dlp#940)) ([ae8ed84](googleapis/java-dlp@ae8ed84)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…-info-reports-plugin to v3.4.1 (#940) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-project-info-reports-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [![age](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/compatibility-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.apache.maven.plugins:maven-project-info-reports-plugin/3.4.1/confidence-slim/3.4.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-speech).

* chore(main): release 3.4.6 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).

…onfig to v1.5.4 (googleapis#940) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-shared-config](https://togithub.com/googleapis/java-shared-config) | `1.5.3` -> `1.5.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/compatibility-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-shared-config/1.5.4/confidence-slim/1.5.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-language).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [requests](https://requests.readthedocs.io) ([source](https://togithub.com/psf/requests), [changelog](https://togithub.com/psf/requests/blob/master/HISTORY.md)) | `==2.27.1` -> `==2.28.1` | [![age](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/compatibility-slim/2.27.1)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/requests/2.28.1/confidence-slim/2.27.1)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-core).

…940)

chore: upgrade native image checks to graalvm-22.3.0 Source-Link: googleapis/synthtool@5e52896 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:27b1b1884dce60460d7521b23c2a73376cba90c0ef3d9f0d32e4bdb786959cfd Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

This PR consists of cherry picks from the https://togithub.com/googleapis/java-datastore/tree/multi-db branch. They include: #928 #940 #942 This also enables parameterized testing for ITDatastoreTest.

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

🤖 I have created a release *beep* *boop* --- ## [2.7.7](googleapis/java-spanner-jdbc@v2.7.6...v2.7.7) (2022-09-16) ### Bug Fixes * Types.BOOLEAN and Types.BIT should have identical behaviour for nullability ([googleapis#920](googleapis/java-spanner-jdbc#920)) ([7a49504](googleapis/java-spanner-jdbc@7a49504)) ### Dependencies * Google-cloud-spanner-bom 6.30.0 ([googleapis#967](googleapis/java-spanner-jdbc#967)) ([f066bed](googleapis/java-spanner-jdbc@f066bed)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([googleapis#963](googleapis/java-spanner-jdbc#963)) ([cd7ea51](googleapis/java-spanner-jdbc@cd7ea51)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([googleapis#966](googleapis/java-spanner-jdbc#966)) ([021523b](googleapis/java-spanner-jdbc@021523b)) * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.29.0 ([googleapis#943](googleapis/java-spanner-jdbc#943)) ([8e225d0](googleapis/java-spanner-jdbc@8e225d0)) * Update dependency com.google.cloud:google-cloud-spanner-bom to v6.29.1 ([googleapis#961](googleapis/java-spanner-jdbc#961)) ([8cace91](googleapis/java-spanner-jdbc@8cace91)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [0.124.7](googleapis/java-storage-nio@v0.124.6...v0.124.7) (2022-06-29) ### Dependencies * update dependency com.google.cloud:google-cloud-storage to v2.9.0 ([#939](googleapis/java-storage-nio#939)) ([f44dddd](googleapis/java-storage-nio@f44dddd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…uration to v1.2.0 (#940) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud.samples:shared-configuration](https://togithub.com/GoogleCloudPlatform/java-repo-tools) | `1.0.23` -> `1.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/compatibility-slim/1.0.23)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud.samples:shared-configuration/1.2.0/confidence-slim/1.0.23)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>GoogleCloudPlatform/java-repo-tools</summary> ### [`v1.2.0`](https://togithub.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.24...v1.2.0) [Compare Source](https://togithub.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.24...v1.2.0) ### [`v1.0.24`](https://togithub.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.23...v1.0.24) [Compare Source](https://togithub.com/GoogleCloudPlatform/java-repo-tools/compare/v1.0.23...v1.0.24) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-pubsub).

mziccard added the api: dns Issues related to the Cloud DNS API. label Apr 19, 2016

googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Apr 19, 2016

mderka and others added 4 commits April 19, 2016 10:52

Disallowed null error in BatchResult. Adjusted doc. (googleapis#921 )

e86a7e8

Integration test for batch. Fixes googleapis#874 . (googleapis#919 )

618b677

* Integration test for batch. Fixes googleapis#874. * Adjusted batch calls in integration tests. * Removed unnecessary copying. * Removed unused import. * Replaced change IDs equals tests with not null.

Added batch support to the local DNS helper. (googleapis#925 )

b75652e

Added batch support to the local DNS helper

Fix LocalDnsHelper Batch handling (googleapis#938 )

357c779

mziccard force-pushed the dns-alpha-batch branch from 5e1b8b4 to 357c779 Compare April 19, 2016 08:58

mziccard force-pushed the dns-alpha-batch branch from ccf9b62 to 738434c Compare April 19, 2016 12:14

Fix minor style errros

2995240

mziccard force-pushed the dns-alpha-batch branch from 738434c to 2995240 Compare April 19, 2016 12:25

mziccard reviewed Apr 19, 2016
View reviewed changes

Comment thread gcloud-java-core/src/main/java/com/google/cloud/BatchResult.java

public abstract class BatchResult<T, E extends BaseServiceException> {

private T result;

private boolean completed = false;

This comment was marked as spam.

Sign in to view

mziccard merged commit e213176 into googleapis:master Apr 20, 2016

mziccard mentioned this pull request May 25, 2016

dns-alpha-batch branch should be deleted #1025

Closed

suztomo pushed a commit that referenced this pull request Feb 1, 2023

deps: update dependency org.checkerframework:checker-qual to v3.28.0 (#…

3dfb126

…940)

chingor13 pushed a commit that referenced this pull request Feb 24, 2026

docs: update wif documentation with enable-imdsv2 flag (#940 )

acc1ce3

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

chingor13 pushed a commit that referenced this pull request Mar 12, 2026

docs: update wif documentation with enable-imdsv2 flag (#940 )

f38b410

Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>

Add support for batches to DNS by mziccard · Pull Request #940 · googleapis/google-cloud-java · GitHub

Uh oh!

Add support for batches to DNS - #940

Add support for batches to DNS#940
mziccard merged 6 commits into
googleapis:masterfrom
mziccard:dns-alpha-batch

mziccard commented Apr 19, 2016 •
edited
Loading

Uh oh!

Uh oh!

googlebot commented Apr 19, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Apr 19, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

+              public abstract class BatchResult<T, E extends BaseServiceException> {
+                private T result;
+                private boolean completed = false;

Add support for batches to DNS by mziccard · Pull Request #940 · googleapis/google-cloud-java · GitHub

Uh oh!

Add support for batches to DNS - #940

Add support for batches to DNS#940mziccard merged 6 commits intogoogleapis:mastergoogleapis/google-cloud-java:masterfrom mziccard:dns-alpha-batchmziccard/gcloud-java:dns-alpha-batchCopy head branch name to clipboard

Conversation

mziccard commented Apr 19, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

googlebot commented Apr 19, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

coveralls commented Apr 19, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add support for batches to DNS#940
mziccard merged 6 commits into
googleapis:masterfrom
mziccard:dns-alpha-batch

mziccard commented Apr 19, 2016 •
edited
Loading