This repository was archived by the owner on Feb 6, 2026. It is now read-only.
feat: allow opt-out auto-population of the log entry metadata on write() - #798
Merged
minherz merged 3 commits intoDec 16, 2021
Merged
feat: allow opt-out auto-population of the log entry metadata on write()#798minherz merged 3 commits into
minherz merged 3 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
allow to opt-out auto populate log entry metadata on write in the write() API and Logging instance levels.
losalex
reviewed
Dec 15, 2021
losalex
suggested changes
Dec 15, 2021
losalex
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Test need to be added
Sorry, something went wrong.
Test WriteOption to out-out auto populating metadata. Test LoggingOption to out-out auto populating metadata. Test default LoggingOption for auto populating metadata. Refactor LoggingOptions tests. Refactor LoggingOptions auto populate metadata getter method.
losalex
approved these changes
Dec 16, 2021
losalex
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
minherz
added a commit
that referenced
this pull request
Dec 30, 2021
…e() (#798) Allows to opt-out auto populate log entry metadata on write in the write() API and Logging instance levels. Tests WriteOption to out-out auto populating metadata. Tests LoggingOption to out-out auto populating metadata. Tests default LoggingOption for auto populating metadata. Refactors LoggingOptions tests. Refactors LoggingOptions auto populate metadata getter method. Fixes cast compilation warning.
minherz
added a commit
that referenced
this pull request
Jan 4, 2022
…e() (#798) Allows to opt-out auto populate log entry metadata on write in the write() API and Logging instance levels. Tests WriteOption to out-out auto populating metadata. Tests LoggingOption to out-out auto populating metadata. Tests default LoggingOption for auto populating metadata. Refactors LoggingOptions tests. Refactors LoggingOptions auto populate metadata getter method. Fixes cast compilation warning.
minherz
added a commit
that referenced
this pull request
Jan 5, 2022
…e() (#798) Allows to opt-out auto populate log entry metadata on write in the write() API and Logging instance levels. Tests WriteOption to out-out auto populating metadata. Tests LoggingOption to out-out auto populating metadata. Tests default LoggingOption for auto populating metadata. Refactors LoggingOptions tests. Refactors LoggingOptions auto populate metadata getter method. Fixes cast compilation warning.
minherz
added a commit
that referenced
this pull request
Jan 7, 2022
…ogs redirection to stdout in JUL handler (#808) Aggregates the following work: - #821 - #812 - #807 - #803 - #798 Fixes #689, #691, #799 and #800 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides opt-out configuration on the Logging instance and Logging.write() API levels to opt-out automatically populate empty metadata fields of the log entries being submitted for writing.
Fixes #689