feat: auto-populate metadata of log entries at write() - #803
Conversation
Sorry, something went wrong.
change visibility of constants in LoggingImpl and MonitoredResourceUtil to use in tests. resolve warning in BaseSystemTest by removing unused var.
losalex
left a comment
There was a problem hiding this comment.
Overall looks good, just asking you to shorten a write function
Sorry, something went wrong.
| builder.setTrace(context.getTraceId()); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This function becomes too bulky and hard to follow - perhaps you can export the part dealing with context into private function?
Sorry, something went wrong.
There was a problem hiding this comment.
I will look into it.
Sorry, something went wrong.
There was a problem hiding this comment.
Thanks
Sorry, something went wrong.
There was a problem hiding this comment.
the trace metadata formatting is moved to a stand-alone method
Sorry, something went wrong.
move the trace metadata formatting to a standalone method. add comments. add unit tests to validate resource metadata prioritizing when passed as WriteOption. fix Context.Builder.setRequest() when passing null.
Populate empty metadata fields of each log entry on write().
Populate empty metadata fields of each log entry on write().
Populate empty metadata fields of each log entry on write().
…ogs redirection to stdout in JUL handler (#808) Aggregates the following work: - #821 - #812 - #807 - #803 - #798 Fixes #689, #691, #799 and #800 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Implements auto-population of metadata (resource info, http requests, trace and span ids, source location).
Respects auto-population LoggingOptions configuration and WriteOption flag.