This repository was archived by the owner on Mar 6, 2026. It is now read-only.
testing: split system tests - #207
Merged
tseaver merged 5 commits intoAug 4, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver @shollyman @busunkim96 I can not assign a reviewer or add a label. Can you review? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I checked the test logs and they work as expected:
Another observation is that the snippets tests are taking long time. Once we move them out, the build will be much faster. |
Sorry, something went wrong.
tseaver
self-requested a review
August 3, 2020 17:45
tseaver
suggested changes
Aug 3, 2020
Copy link
Copy Markdown
Contributor
Author
|
@tseaver Thanks, I opened googleapis/synthtool#713 which will allow us to use the template. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver Tests are passing. I rebased to the master. PTAL |
Sorry, something went wrong.
tseaver
self-requested a review
August 4, 2020 16:35
tseaver
approved these changes
Aug 4, 2020
1 task
jmgreger
pushed a commit
to jmgreger/python-bigquery
that referenced
this pull request
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I manually run synthtool with the changes in googleapis/synthtool#712
Motivation: #191
Note that noxfile.py is skipped, so I manually updated it (probably ok)