FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tests: split out snippets builds by tseaver · Pull Request #219 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

tests: split out snippets builds - #219

Merged
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
191-split-out-snippets-builds
Oct 16, 2020
ConversationCommits (5)ChecksFiles changed
Merged

tests: split out snippets builds#219
gcf-merge-on-green[bot] merged 5 commits into
masterfrom
191-split-out-snippets-builds

Conversation

tseaver commented Aug 10, 2020

Copy link
Copy Markdown
Contributor

@tmatsuo Emulating PR #207. I don't know if I'm missing anything: e.g., I don't quite understand what the split_system_tests=True does in the synth.py there.

Toward #191

tseaver requested a review from tmatsuo August 10, 2020 19:25
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 10, 2020
product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Aug 21, 2020
tmatsuo reviewed Oct 2, 2020
View reviewed changes

tmatsuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry for the late reply. Once we agree on the env var name, I can make a change for allowing the env var.

Comment thread .kokoro/presubmit/presubmit.cfg Outdated
value: "false"
}
env_vars: {
key: "RUN_SNIPPETS"

tmatsuo Oct 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think we need to allow this envvar in the Kokoro config in google3.
Also how about RUN_SNIPPETS_TESTS for consistensy?

tswast Oct 2, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

RUN_SNIPPETS_TESTS sounds good to me

tmatsuo Oct 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added to the Kokoro side configuration files.

tswast requested a review from a team October 16, 2020 19:37
tswast mentioned this pull request Oct 16, 2020
Merged
tswast added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Oct 16, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 16, 2020

gcf-merge-on-green Bot commented Oct 16, 2020

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment

gcf-merge-on-green Bot commented Oct 16, 2020

Copy link
Copy Markdown

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

tmatsuo approved these changes Oct 16, 2020
View reviewed changes
Comment thread .kokoro/presubmit/presubmit.cfg Outdated
value: "false"
}
env_vars: {
key: "RUN_SNIPPETS"

tmatsuo Oct 15, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Added to the Kokoro side configuration files.

gcf-merge-on-green Bot merged commit 29dd573 into master Oct 16, 2020
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 16, 2020
tswast deleted the 191-split-out-snippets-builds branch July 27, 2021 21:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
tmatsuo tmatsuo approved these changes
tswast tswast approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL