FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: split system tests across modules by tswast · Pull Request #448 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

refactor: split system tests across modules - #448

Closed
tswast wants to merge 2 commits into
googleapis:masterfrom
tswast:issue56-load-dataframe-datetime
ConversationCommits (2)ChecksFiles changed
Closed

refactor: split system tests across modules#448
tswast wants to merge 2 commits into
googleapis:masterfrom
tswast:issue56-load-dataframe-datetime

Conversation

tswast commented Dec 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

This should make it easier to see which pandas tests
we have and which we are missing.

Despite the branch name, not exactly related to #56, but I realized I was having trouble determining if this pandas DATETIME use case was tested when all system tests were in the same file.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #366

refactor: split system tests across modules
4939ab8 
This should make it easier to see which pandas tests
we have and which we are missing.
tswast requested review from a team and stephaniewang526 and removed request for a team December 22, 2020 18:30
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 22, 2020
product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Dec 22, 2020
tswast requested review from plamut and removed request for stephaniewang526 January 7, 2021 15:34
tswast added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 19, 2021

tswast commented Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

To make this easier to review, I think I'll do this in multiple PRs. I don't want to accidentally miss a test.

tswast commented Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

#475 should be merged before this. I'll probably split the "moves" into separate PRs as well (dbapi first, then pandas/arrow)

plamut reviewed Feb 27, 2021
View reviewed changes

plamut left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks a step in the right direction. We need to resolve a few the merge conflicts, though.

@tswast Or do you plan to abandon this and submit multiple smaller PRs instead?

tswast commented Mar 11, 2021

Copy link
Copy Markdown
Contributor Author

@tswast Or do you plan to abandon this and submit multiple smaller PRs instead?

I'll go with multiple PRs. (One for pandas and one for DB-API). I fear if I try to resolve merge conflicts, I'll accidentally delete some tests.

tswast closed this Mar 11, 2021
tswast mentioned this pull request Mar 11, 2021
Merged
4 tasks
gcf-merge-on-green Bot pushed a commit that referenced this pull request Mar 15, 2021
refactor: split pandas system tests to new module (#548)
efdf1c6 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Follow-up to #448

Towards #366
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Mar 6, 2026
refactor: split pandas system tests to new module (#548)
fce0fa2 
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/python-bigquery/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Follow-up to googleapis/python-bigquery#448

Towards #366
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
plamut plamut left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL