FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

refactor: move system tests into `tests/system` directory by tswast · Pull Request #475 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

refactor: move system tests into tests/system directory - #475

Merged
gcf-merge-on-green[bot] merged 8 commits into
googleapis:masterfrom
tswast:system.py-step1-move
Jan 20, 2021
ConversationCommits (8)ChecksFiles changed
Merged

refactor: move system tests into tests/system directory#475
gcf-merge-on-green[bot] merged 8 commits into
googleapis:masterfrom
tswast:system.py-step1-move

Conversation

tswast commented Jan 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

This aligns more closely with the templates from synthtool.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards #366

refactor: move system tests into tests/system directory
db45efb 
This aligns more closely with the templates from synthtool.
tswast requested review from a team and steffnay and removed request for a team January 19, 2021 15:59
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 19, 2021
product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 19, 2021
tswast mentioned this pull request Jan 19, 2021
Closed
4 tasks
tswast requested review from plamut and shollyman January 19, 2021 16:08

tswast commented Jan 19, 2021

Copy link
Copy Markdown
Contributor Author

prerelease-deps-3.8 test failures are both in the unit tests. https://source.cloud.google.com/results/invocations/aed3c05e-366a-404e-b90a-ecb134327e41/targets/cloud-devrel%2Fclient-libraries%2Fpython%2Fgoogleapis%2Fpython-bigquery%2Fpresubmit%2Fprerelease-deps-3.8/log

Neither seem particularly related to pyarrow (failure due to bad nightly) or to this change.

Perhaps there's some state that's being held onto when the unit tests are run in the same pytest run as the system tests?

plamut approved these changes Jan 20, 2021
View reviewed changes

plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Apart from a license header nit, it looks good to me. 👍

Comment thread tests/system/__init__.py Outdated
Comment thread tests/system/test_magics.py
Comment on lines +23 to +27
IPython = pytest.importorskip("IPython")
io = pytest.importorskip("IPython.utils.io")
pandas = pytest.importorskip("pandas")
tools = pytest.importorskip("IPython.testing.tools")
interactiveshell = pytest.importorskip("IPython.terminal.interactiveshell")

plamut Jan 20, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Nice, this is IMO more clean that those skipIf decorators. 👍

Comment thread tests/system/test_client.py
JOB_TIMEOUT = 120 # 2 minutes
WHERE = os.path.abspath(os.path.dirname(__file__))
JOB_TIMEOUT = 120 # 2 minute
DATA_PATH = pathlib.Path(__file__).parent.parent / "data"

plamut Jan 20, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Love these small improvements and utilizing the goodies Python 3 offers!

Update tests/system/__init__.py
6a778a5 
Co-authored-by: Peter Lamut <plamut@users.noreply.github.com>
tswast added the automerge Merge the pull request once unit tests and other checks pass. label Jan 20, 2021
gcf-merge-on-green Bot merged commit 9f6556c into googleapis:master Jan 20, 2021
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 20, 2021
tswast deleted the system.py-step1-move branch January 21, 2021 15:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

steffnay Awaiting requested review from steffnay
shollyman Awaiting requested review from shollyman
1 more reviewer
plamut plamut approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

Back | FazBrowse Home | New Git URL