FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: don't try to close closed DB API cursors by betodealmeida · Pull Request #498 · googleapis/python-bigquery · GitHub

This repository was archived by the owner on Mar 6, 2026. It is now read-only.
/ python-bigquery Public archive

fix: don't try to close closed DB API cursors - #498

Merged
plamut merged 1 commit into
googleapis:masterfrom
betodealmeida:dont_close_closed_cursors
Jan 29, 2021
Merged

fix: don't try to close closed DB API cursors#498
plamut merged 1 commit into
googleapis:masterfrom
betodealmeida:dont_close_closed_cursors

Conversation

betodealmeida commented Jan 28, 2021
edited by plamut
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #497 🦕

product-auto-label Bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 28, 2021

google-cla Bot commented Jan 28, 2021

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 28, 2021

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 28, 2021
betodealmeida force-pushed the dont_close_closed_cursors branch from df9776b to 5904b52 Compare January 28, 2021 20:57
betodealmeida force-pushed the dont_close_closed_cursors branch from 5904b52 to f90188f Compare January 28, 2021 22:37
betodealmeida marked this pull request as ready for review January 28, 2021 22:37
betodealmeida requested review from a team and steffnay and removed request for a team January 28, 2021 22:37
plamut added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2021
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 29, 2021
plamut changed the title fix: don't try to close closed cursors fix: don't try to close closed DB API cursors Jan 29, 2021

plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks good, thank you!

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Closing a connection tries to close already closed cursors

3 participants


Back | FazBrowse Home | New Git URL