This repository was archived by the owner on Mar 6, 2026. It is now read-only.
feat: add mtls feature - #492
Merged
tswast merged 6 commits intoFeb 5, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
arithmetic1728
commented
Jan 28, 2021
Comment thread
google/cloud/bigquery/client.py
Outdated
arithmetic1728
force-pushed
the
mtls_rebase
branch
from
66bc033 to
e716ea6
Compare
January 28, 2021 23:08
arithmetic1728
marked this pull request as ready for review
February 1, 2021 09:57
arithmetic1728
requested review from
a team,
busunkim96,
steffnay and
tswast
and removed request for
a team
February 1, 2021 09:57
tswast
reviewed
Feb 4, 2021
tswast
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Looking good, thanks! Just a few nits.
Sorry, something went wrong.
Comment thread
google/cloud/bigquery/_http.py
Comment thread
google/cloud/bigquery/client.py
Comment thread
google/cloud/bigquery/client.py
Comment thread
tests/unit/test__http.py
Outdated
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Tim Swast <swast@google.com>
Co-authored-by: Tim Swast <swast@google.com>
Copy link
Copy Markdown
Contributor
Author
Committed all the suggested changes. Thank you! |
Sorry, something went wrong.
tswast
approved these changes
Feb 5, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Feb 10, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [2.8.0](https://www.github.com/googleapis/python-bigquery/compare/v2.7.0...v2.8.0) (2021-02-08) ### Features * add mtls support to client ([#492](https://www.github.com/googleapis/python-bigquery/issues/492)) ([1823cad](https://www.github.com/googleapis/python-bigquery/commit/1823cadee3acf95c516d0479400e4175349ea199)) ### Bug Fixes * don't try to close closed cursors ([#498](https://www.github.com/googleapis/python-bigquery/issues/498)) ([bf44e7b](https://www.github.com/googleapis/python-bigquery/commit/bf44e7b67d2de41c13053a4550484b9ea049db3e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://google.aip.dev/auth/4114
googlers see this doc for more details.
Part of the mtls feature is implemented in googleapis/python-cloud-core#75, and will be released as version 1.16.0.
This PR adds the mtls feature to bigquery client lib. Note that:
(1) if the python-cloud-core version is < 1.16.0, this PR does nothing, it is backward compatible and won't break any current users.
(2) if the user sets GOOGLE_API_USE_CLIENT_CERTIFICATE env var to "true" to trigger mtls, then the PR checks python-cloud-core version. It throws an exception asking the user to bump the version, if the version < 1.16.0. So probably it is a good idea to release python-cloud-core 1.16.0 before merging this PR.
(3) the unit tests work for both python-cloud-core versions, so unit test shouldn't break after the upgrading in the future.