This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix(db_api): allow file path for credentials - #221
Merged
larkee merged 5 commits intoMar 10, 2021
Merged
larkee merged 5 commits into
larkee merged 5 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
larkee
reviewed
Feb 8, 2021
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM, although I'm a little concerned about having both a credentials and a credentials_uri kwarg for the same method. Did you consider any alternatives?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@larkee Yes i think, If we combine credentials and credentials_uri and make conditions on Object and string but it would be little bit confusing. |
Sorry, something went wrong.
larkee
reviewed
Feb 22, 2021
larkee
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Just some minor doc changes to try minimize confusion
Sorry, something went wrong.
Comment thread
google/cloud/spanner_dbapi/connection.py
Outdated
| @@ -356,7 +356,9 @@ def connect( | |||
| :type credentials: :class:`~google.auth.credentials.Credentials` | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Suggested change
| :type credentials: :class:`~google.auth.credentials.Credentials` | |
| :type credentials: Union[:class:`~google.auth.credentials.Credentials`, str] |
Sorry, something went wrong.
Comment thread
google/cloud/spanner_dbapi/connection.py
Outdated
| :param credentials: (Optional) The authorization credentials to attach to | ||
| requests. These credentials identify this application | ||
| to the service. If none are specified, the client will | ||
| to the service. Or a string specifying (path) where to retrieve |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Perhaps:
(Optional) The authorization credentials to attach to requests. These credentials identify this application to the service. These credentials may be specified as a file path indicating where to retrieve the service account JSON for the credentials to connect to Cloud Spanner. If none are specified, the client will attempt to ascertain the credentials from the environment.
Sorry, something went wrong.
…into spanner_issue_220
Copy link
Copy Markdown
Contributor
Author
|
System test failed with error google.api_core.exceptions.ResourceExhausted: 429 Project 1065521786570 cannot add 1 nodes in region us-central1. not related to changes. |
Sorry, something went wrong.
larkee
approved these changes
Mar 10, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Mar 25, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.3.0](https://www.github.com/googleapis/python-spanner/compare/v3.2.0...v3.3.0) (2021-03-25) ### Features * add encryption_info to Database ([#284](https://www.github.com/googleapis/python-spanner/issues/284)) ([2fd0352](https://www.github.com/googleapis/python-spanner/commit/2fd0352f695d7ab85e57d8c4388f42f91cf39435)) * add support for CMEK ([#105](https://www.github.com/googleapis/python-spanner/issues/105)) ([e990ff7](https://www.github.com/googleapis/python-spanner/commit/e990ff70342e7c2e27059e82c8d74cce39eb85d0)) * add support for custom timeout and retry parameters in execute_update method in transactions ([#251](https://www.github.com/googleapis/python-spanner/issues/251)) ([8abaebd](https://www.github.com/googleapis/python-spanner/commit/8abaebd9edac198596e7bd51d068d50147d0391d)) * added retry and timeout params to partition read in database and snapshot class ([#278](https://www.github.com/googleapis/python-spanner/issues/278)) ([1a7c9d2](https://www.github.com/googleapis/python-spanner/commit/1a7c9d296c23dfa7be7b07ea511a4a8fc2c0693f)) * **db_api:** support executing several DDLs separated by semicolon ([#277](https://www.github.com/googleapis/python-spanner/issues/277)) ([801ddc8](https://www.github.com/googleapis/python-spanner/commit/801ddc87434ff9e3c86b1281ebfeac26195c06e8)) ### Bug Fixes * avoid consuming pending null values when merging ([#286](https://www.github.com/googleapis/python-spanner/issues/286)) ([c6cba9f](https://www.github.com/googleapis/python-spanner/commit/c6cba9fbe4c717f1f8e2a97e3f76bfe6b956e55b)) * **db_api:** allow file path for credentials ([#221](https://www.github.com/googleapis/python-spanner/issues/221)) ([1de0284](https://www.github.com/googleapis/python-spanner/commit/1de028430b779a50d38242fe70567e92b560df5a)) * **db_api:** ensure DDL statements are being executed ([#290](https://www.github.com/googleapis/python-spanner/issues/290)) ([baa02ee](https://www.github.com/googleapis/python-spanner/commit/baa02ee1a352f7c509a3e169927cf220913e521f)) * **db_api:** revert Mutations API usage ([#285](https://www.github.com/googleapis/python-spanner/issues/285)) ([e5d4901](https://www.github.com/googleapis/python-spanner/commit/e5d4901e9b7111b39dfec4c56032875dc7c6e74c)) ### Documentation * fix docstring types and typos ([#259](https://www.github.com/googleapis/python-spanner/issues/259)) ([1b0ce1d](https://www.github.com/googleapis/python-spanner/commit/1b0ce1d2986085ce4033cf773eb6c5d3b904473c)) * fix snapshot usage ([#291](https://www.github.com/googleapis/python-spanner/issues/291)) ([eee2181](https://www.github.com/googleapis/python-spanner/commit/eee218164c3177586b73278aa21495280984af89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220