This repository was archived by the owner on Jun 8, 2026. It is now read-only.
feat: add support for custom timeout and retry parameters in execute_update method in transactions - #251
Merged
vi3k6i5 merged 7 commits intoMar 11, 2021
Merged
feat: add support for custom timeout and retry parameters in execute_update method in transactions#251vi3k6i5 merged 7 commits into
vi3k6i5 merged 7 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…python-spanner into ft-custom-timeout-retry-2
olavloite
reviewed
Mar 3, 2021
olavloite
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This change in itself seems reasonable to me, but I don't know the exact background for this change. From the description of the PR it seems that the goal is to add custom timeout and retry parameters for transactions. This PR only introduces timeout and retry parameters for single update statements in a transaction. It does not:
- Add the possibility to specify a timeout for Begin, Commit or ExecuteBatchDML statements in a transaction.
- Add the possibility to set a timeout for the entire transaction (which I would also expect not to be something we want, but I'm a little confused by the PR title)
Is this intentional?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Thanks @olavloite . I Updated the PR title, that should clarify it. We were planning to add this parameter 1 by 1 in other places as well. @larkee : Shall I update the same PR with other implementations as well? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I think this is fine since we may want to see how this looks for one method first. Then in the next PR, we can do multiples of these. |
Sorry, something went wrong.
olavloite
approved these changes
Mar 4, 2021
thiagotnunes
reviewed
Mar 5, 2021
thiagotnunes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This looks good to me, but I have a few questions:
- Are we going to add custom timeouts for other methods as well?
- Are we also planning on making it possible to override the default retry strategy of the methods?
- Do we want to provide a way so that a timeout is set during initialization and the caller does not have to specify the timeout on every call (or do we already have this functionality)?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Sorry, I missed the above comments, so I think it looks good, since this is the first step of the feature. |
Sorry, something went wrong.
thiagotnunes
approved these changes
Mar 5, 2021
Copy link
Copy Markdown
Contributor
|
Please wait for @larkee 's review before merging, as they have more context on the library implementation. |
Sorry, something went wrong.
larkee
suggested changes
Mar 9, 2021
Comment thread
google/cloud/spanner_v1/transaction.py
Comment thread
google/cloud/spanner_v1/transaction.py
Outdated
larkee
approved these changes
Mar 10, 2021
vi3k6i5
commented
Mar 10, 2021
vi3k6i5
left a comment
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Build check failed, retrying.
Sorry, something went wrong.
larkee
reviewed
Mar 10, 2021
Comment thread
google/cloud/spanner_v1/transaction.py
Outdated
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Mar 25, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.3.0](https://www.github.com/googleapis/python-spanner/compare/v3.2.0...v3.3.0) (2021-03-25) ### Features * add encryption_info to Database ([#284](https://www.github.com/googleapis/python-spanner/issues/284)) ([2fd0352](https://www.github.com/googleapis/python-spanner/commit/2fd0352f695d7ab85e57d8c4388f42f91cf39435)) * add support for CMEK ([#105](https://www.github.com/googleapis/python-spanner/issues/105)) ([e990ff7](https://www.github.com/googleapis/python-spanner/commit/e990ff70342e7c2e27059e82c8d74cce39eb85d0)) * add support for custom timeout and retry parameters in execute_update method in transactions ([#251](https://www.github.com/googleapis/python-spanner/issues/251)) ([8abaebd](https://www.github.com/googleapis/python-spanner/commit/8abaebd9edac198596e7bd51d068d50147d0391d)) * added retry and timeout params to partition read in database and snapshot class ([#278](https://www.github.com/googleapis/python-spanner/issues/278)) ([1a7c9d2](https://www.github.com/googleapis/python-spanner/commit/1a7c9d296c23dfa7be7b07ea511a4a8fc2c0693f)) * **db_api:** support executing several DDLs separated by semicolon ([#277](https://www.github.com/googleapis/python-spanner/issues/277)) ([801ddc8](https://www.github.com/googleapis/python-spanner/commit/801ddc87434ff9e3c86b1281ebfeac26195c06e8)) ### Bug Fixes * avoid consuming pending null values when merging ([#286](https://www.github.com/googleapis/python-spanner/issues/286)) ([c6cba9f](https://www.github.com/googleapis/python-spanner/commit/c6cba9fbe4c717f1f8e2a97e3f76bfe6b956e55b)) * **db_api:** allow file path for credentials ([#221](https://www.github.com/googleapis/python-spanner/issues/221)) ([1de0284](https://www.github.com/googleapis/python-spanner/commit/1de028430b779a50d38242fe70567e92b560df5a)) * **db_api:** ensure DDL statements are being executed ([#290](https://www.github.com/googleapis/python-spanner/issues/290)) ([baa02ee](https://www.github.com/googleapis/python-spanner/commit/baa02ee1a352f7c509a3e169927cf220913e521f)) * **db_api:** revert Mutations API usage ([#285](https://www.github.com/googleapis/python-spanner/issues/285)) ([e5d4901](https://www.github.com/googleapis/python-spanner/commit/e5d4901e9b7111b39dfec4c56032875dc7c6e74c)) ### Documentation * fix docstring types and typos ([#259](https://www.github.com/googleapis/python-spanner/issues/259)) ([1b0ce1d](https://www.github.com/googleapis/python-spanner/commit/1b0ce1d2986085ce4033cf773eb6c5d3b904473c)) * fix snapshot usage ([#291](https://www.github.com/googleapis/python-spanner/issues/291)) ([eee2181](https://www.github.com/googleapis/python-spanner/commit/eee218164c3177586b73278aa21495280984af89)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Added support for custom timeout and retry parameters in transactions.
Fixes #71 🦕