FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: add configurable leader placement support by zoercai · Pull Request #399 · googleapis/python-spanner · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.
/ python-spanner Public archive

feat: add configurable leader placement support - #399

Merged
gcf-merge-on-green[bot] merged 9 commits into
googleapis:masterfrom
zoercai:cmmr-1
Jul 29, 2021
ConversationCommits (9)ChecksFiles changed
Merged

feat: add configurable leader placement support#399
gcf-merge-on-green[bot] merged 9 commits into
googleapis:masterfrom
zoercai:cmmr-1

Conversation

zoercai commented Jul 6, 2021

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

zoercai requested review from a team, hengfengli, larkee and skuruppu July 6, 2021 04:28
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2021
product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 6, 2021
zoercai added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement. labels Jul 6, 2021
google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 6, 2021
hengfengli approved these changes Jul 6, 2021
View reviewed changes

hengfengli left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM.

product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jul 6, 2021

hengfengli commented Jul 21, 2021

Copy link
Copy Markdown

Hi @zoercai , the error is:

E   google.api_core.exceptions.FailedPrecondition: 400 The instance configuration projects/***/instanceConfigs/regional-us-central1 does not support default_leader settings.

We need to create a multi-region instance in order to test default_leader. default_leader does not work for a regional instance. Two options we have here:

  1. Create a multi-region instance to test default_leader
  2. Do the integration test in sample tests (this is what we do in java)

hengfengli removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 21, 2021
zoercai mentioned this pull request Jul 26, 2021
Merged
larkee suggested changes Jul 28, 2021
View reviewed changes

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Implementation LGTM.

Some changes are needed for the system tests

Comment thread tests/system/test_system.py Outdated
Comment thread tests/system/test_system.py Outdated
Comment thread tests/system/test_system.py Outdated
zoercai requested a review from larkee July 29, 2021 02:31
zoercai added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2021
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2021
larkee approved these changes Jul 29, 2021
View reviewed changes

larkee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Minor nit for Python style but the rest LGTM 👍

Comment thread tests/system/test_system.py Outdated
zoercai added the automerge Merge the pull request once unit tests and other checks pass. label Jul 29, 2021
gcf-merge-on-green Bot merged commit 7f1b120 into googleapis:master Jul 29, 2021
gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 29, 2021
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jul 30, 2021
chore: release 3.7.0 (#398)
89fe076 
🤖 I have created a release \*beep\* \*boop\*
---
## [3.7.0](https://www.github.com/googleapis/python-spanner/compare/v3.6.0...v3.7.0) (2021-07-29)


### Features

* add always_use_jwt_access ([#381](https://www.github.com/googleapis/python-spanner/issues/381)) ([0f1a5de](https://www.github.com/googleapis/python-spanner/commit/0f1a5ded572685a96d29a60c959cb00a48f7a87f))
* add configurable leader placement support ([#399](https://www.github.com/googleapis/python-spanner/issues/399)) ([7f1b120](https://www.github.com/googleapis/python-spanner/commit/7f1b1209e62062014545cf959d41f04184552eec))
* add sample for low cost instances ([#392](https://www.github.com/googleapis/python-spanner/issues/392)) ([3f4f93f](https://www.github.com/googleapis/python-spanner/commit/3f4f93f75f5585a82047bf8d83a24622ad776ecb))


### Bug Fixes

* avoid bad version of `opentelemetry-instrumentation` ([#429](https://www.github.com/googleapis/python-spanner/issues/429)) ([1620c12](https://www.github.com/googleapis/python-spanner/commit/1620c12a56e0d007cf010690bab303db06d0c914))
* **deps:** pin 'google-{api,cloud}-core' to allow 2.x versions ([#415](https://www.github.com/googleapis/python-spanner/issues/415)) ([b0455d0](https://www.github.com/googleapis/python-spanner/commit/b0455d0ab657cd053a7527e99bdbfadc4de23b30))
* disable always_use_jwt_access ([c37bf21](https://www.github.com/googleapis/python-spanner/commit/c37bf21afdf417757eff67fe8500aa65f49fd5ad))
* disable always_use_jwt_access ([#395](https://www.github.com/googleapis/python-spanner/issues/395)) ([c37bf21](https://www.github.com/googleapis/python-spanner/commit/c37bf21afdf417757eff67fe8500aa65f49fd5ad))
* enable self signed jwt for grpc ([#427](https://www.github.com/googleapis/python-spanner/issues/427)) ([2487800](https://www.github.com/googleapis/python-spanner/commit/2487800e31842a44dcc37937c325e130c8c926b0))
* support merging for NUMERIC values ([#434](https://www.github.com/googleapis/python-spanner/issues/434)) ([06b4215](https://www.github.com/googleapis/python-spanner/commit/06b4215f76ae806eba1d0d07115c8c90b8c7482d)), closes [#433](https://www.github.com/googleapis/python-spanner/issues/433)


### Documentation

* fix docstring for session.py ([#387](https://www.github.com/googleapis/python-spanner/issues/387)) ([3132587](https://www.github.com/googleapis/python-spanner/commit/3132587453f7bd0be72ebc393626b5c8b1bab982))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

skuruppu Awaiting requested review from skuruppu
2 more reviewers
hengfengli hengfengli approved these changes
larkee larkee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/python-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL