Current connections reset mechanism doesn't drop read_only property of a connection returned back to a connections pool. It makes the following cases possible:
user initiates a ReadOnly connection, executes some operations and returnes the connection back to the pool (automatically)
user initiates the next connection, without making it ReadOnly, but the pool returns the connection, which was toggled to the ReadOnly mode earlier (as it's a pool, it returns the connections created earlier, it is its purpos).
Such a situation can be very unexpected and will require for user to write additional logic to understand if the connection can be used in their case. To avoid it, we better drop read_only attribute to its default value when a connection is returned back to pool.
P.S. because of the same reasons we're already dropping staleness attribute on a connection reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner
Issues related to the googleapis/python-spanner-sqlalchemy API.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current connections reset mechanism doesn't drop read_only property of a connection returned back to a connections pool. It makes the following cases possible:
Such a situation can be very unexpected and will require for user to write additional logic to understand if the connection can be used in their case. To avoid it, we better drop read_only attribute to its default value when a connection is returned back to pool.
P.S. because of the same reasons we're already dropping staleness attribute on a connection reset.