This repository was archived by the owner on May 14, 2026. It is now read-only.
feat: rollback a connection returned back to pool - #193
Merged
vi3k6i5 merged 13 commits intoJan 28, 2022
Merged
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
added 11 commits
January 10, 2022 11:35
Copy link
Copy Markdown
Contributor
|
Hi @IlyaFaer : Can you fix the conflict in the PR? PS: Anything I can help with so you can send it out for review? |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
IlyaFaer
marked this pull request as ready for review
January 28, 2022 11:24
vi3k6i5
approved these changes
Jan 28, 2022
vi3k6i5
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Branched from another PR: #189
Fixes: #192
By default connection reset function rollbacks any connection returned back to pool. Adding this behaviour into our override.