FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: add change in 'Blob.custom_time' to changes by haim0n · Pull Request #323 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

fix: add change in 'Blob.custom_time' to changes - #323

Merged
tseaver merged 1 commit into
googleapis:masterfrom
haim0n:master
Nov 24, 2020
Merged

fix: add change in 'Blob.custom_time' to changes#323
tseaver merged 1 commit into
googleapis:masterfrom
haim0n:master

Conversation

haim0n commented Nov 22, 2020

Copy link
Copy Markdown
Contributor

This way '_PropertyMixin.patch' will send them to server.

Fixes #322 🦕

google-cla Bot commented Nov 22, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

product-auto-label Bot added the api: storage Issues related to the googleapis/python-storage API. label Nov 22, 2020
google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Nov 22, 2020
google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 22, 2020
tseaver added a commit that referenced this pull request Nov 24, 2020
Also, add test assertions for 'metadata' setter for the same issue.

Closes #323

tseaver left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the patch. Please add unit test assertions (as I did in PR #325, which I am closing in favor of this one).

This way '_PropertyMixin.patch' will send them to server.
Fixes googleapis#322

haim0n commented Nov 24, 2020

Copy link
Copy Markdown
Contributor Author

Thanks for the patch. Please add unit test assertions (as I did in PR #325, which I am closing in favor of this one).

done

tseaver added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 24, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 24, 2020
tseaver removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 24, 2020
tseaver changed the title fix: Add change in 'Blob.custom_time' to changes fix: add change in 'Blob.custom_time' to changes Nov 24, 2020
tseaver merged commit 5174154 into googleapis:master Nov 24, 2020
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
cojenco pushed a commit to cojenco/python-storage that referenced this pull request Oct 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: storage Issues related to the googleapis/python-storage API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

'Blob.custom_time' setter doesnt update '_changes'

3 participants


Back | FazBrowse Home | New Git URL