FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: add change in 'Blob.custom_time' to changes by haim0n · Pull Request #323 · googleapis/python-storage · GitHub

This repository was archived by the owner on Mar 31, 2026. It is now read-only.
/ python-storage Public archive

fix: add change in 'Blob.custom_time' to changes #323

Merged
tseaver merged 1 commit into from
Nov 24, 2020
Conversation 3 Commits 1 Checks 0 Files changed
Merged

fix: add change in 'Blob.custom_time' to changes #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension .py  (2) All 1 file type selected
Viewed files
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Unified
Split
Hide whitespace
Diff view
Unified
Split
Hide whitespace
2 changes: 1 addition & 1 deletion google/cloud/storage/blob.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3613,7 +3613,7 @@ def custom_time(self, value):
if value is not None:
value = _datetime_to_rfc3339(value)

self._properties["customTime"] = value
self._patch_property("customTime", value)


def _get_encryption_headers(key, source=False):
Expand Down
4 changes: 4 additions & 0 deletions tests/unit/test_blob.py
Show comments
View file
Open in desktop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Original file line number Diff line number Diff line change
Expand Up @@ -3987,6 +3987,7 @@ def test_update_storage_class_w_generation_match(self):
if_generation_match=GENERATION_NUMBER,
if_source_generation_match=SOURCE_GENERATION_NUMBER,
)

self.assertEqual(blob.storage_class, "NEARLINE")

kw = connection._requested
Expand Down Expand Up @@ -4236,6 +4237,7 @@ def test_metadata_setter(self):
self.assertIsNone(blob.metadata)
blob.metadata = METADATA
self.assertEqual(blob.metadata, METADATA)
self.assertIn("metadata", blob._changes)

def test_metadata_setter_w_nan(self):
BLOB_NAME = "blob-name"
Expand All @@ -4246,6 +4248,7 @@ def test_metadata_setter_w_nan(self):
blob.metadata = METADATA
value = blob.metadata["foo"]
self.assertIsInstance(value, str)
self.assertIn("metadata", blob._changes)

def test_metageneration(self):
BUCKET = object()
Expand Down Expand Up @@ -4444,6 +4447,7 @@ def test_custom_time_setter(self):
self.assertIsNone(blob.custom_time)
blob.custom_time = TIMESTAMP
self.assertEqual(blob.custom_time, TIMESTAMP)
self.assertIn("customTime", blob._changes)

def test_custom_time_setter_none_value(self):
from google.cloud._helpers import _RFC3339_MICROS
Expand Down
Back | FazBrowse Home | New Git URL