FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Allow GPUTexture where GPUTextureView is used by beaufortfrancois · Pull Request #5228 · gpuweb/gpuweb · GitHub

/ gpuweb Public

Allow GPUTexture where GPUTextureView is used - #5228

Merged
dneto0 merged 10 commits into
gpuweb:mainfrom
beaufortfrancois:texture-binding-resource
Jul 3, 2025
ConversationCommits (10)ChecksFiles changed
Merged

Allow GPUTexture where GPUTextureView is used#5228
dneto0 merged 10 commits into
gpuweb:mainfrom
beaufortfrancois:texture-binding-resource

Conversation

beaufortfrancois commented Jun 20, 2025

Copy link
Copy Markdown
Contributor

This PR adds GPUTexture support to the following attributes:

  • GPUBindingResource
  • GPURenderPassColorAttachment view
  • GPURenderPassColorAttachment resolveTarget
  • GPURenderPassDepthStencilAttachment view

It also updates parts of the WebGPU and WGSL specs that I've missed when adding GPUBuffer in GPUBindingResource with #5193

FIX #5215

github-actions Bot commented Jun 20, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Previews, as seen when this build job started (b3898a4):
WebGPU webgpu.idl | Explainer | Correspondence Reference
WGSL grammar.js | wgsl.lalr.txt

beaufortfrancois mentioned this pull request Jun 24, 2025
Merged
8 tasks
beaufortfrancois requested a review from toji June 25, 2025 13:39
toji reviewed Jun 25, 2025
View reviewed changes

toji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I missed last weeks meeting so I don't know if this was agreed upon behavior. Doesn't seem like the linked issue reached a resolution, at least.

Assuming that the group has agreed on this, though, the PR looks good. Just a couple of nits.

Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
beaufortfrancois commented Jun 26, 2025
View reviewed changes

beaufortfrancois left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@toji Thanks for the review! My understanding from past meeting notes is that it had reached consensus.

Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
toji approved these changes Jun 26, 2025
View reviewed changes

toji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for the updates! WebGPU spec LGTM, but would you mind getting someone from the WGSL side (like @dneto0) to approve the WGSL spec changes?

beaufortfrancois requested a review from dneto0 June 27, 2025 07:22
kainino0x reviewed Jun 28, 2025
View reviewed changes
Comment thread spec/index.bs Outdated
kainino0x added the needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet label Jul 2, 2025
kainino0x approved these changes Jul 2, 2025
View reviewed changes
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread spec/index.bs Outdated

beaufortfrancois commented Jul 2, 2025

Copy link
Copy Markdown
Contributor Author

@dneto0 Please review

kainino0x approved these changes Jul 2, 2025
View reviewed changes
Comment thread wgsl/index.bs Outdated
Comment thread spec/index.bs Outdated
Comment thread wgsl/index.bs
toji approved these changes Jul 2, 2025
View reviewed changes

toji left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Kai's edits LGTM.

dneto0 approved these changes Jul 3, 2025
View reviewed changes

dneto0 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. Thanks!

dneto0 merged commit e93276a into gpuweb:main Jul 3, 2025
beaufortfrancois mentioned this pull request Jul 4, 2025
Merged

beaufortfrancois commented Jul 4, 2025

Copy link
Copy Markdown
Contributor Author

@kainino0x Shall we update webgpu.h as well or is it only for Javascript?

kainino0x commented Jul 7, 2025

Copy link
Copy Markdown
Contributor

@beaufortfrancois no, we'll do this only for Javascript. It's just an implicit .createView() and there's no issue if the C API user has to do that themselves.

toji commented Jul 7, 2025

Copy link
Copy Markdown
Member

I'm happy to do the Blink change unless this is something you wanted to tackle, @beaufortfrancois?

beaufortfrancois commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

I already had one ;) Feel free to review https://chromium-review.googlesource.com/c/chromium/src/+/6656722

kainino0x pushed a commit to gpuweb/types that referenced this pull request Jul 7, 2025
Allow GPUTexture where GPUTextureView is used (#186)
5cbe48e 
This PR reflects the following spec changes:
- gpuweb/gpuweb#5228
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 9, 2025
WebGPU: Allow GPUTexture where GPUTextureView is used
d172c01 
Spec PR: gpuweb/gpuweb#5228

Change-Id: I260164692b6476bb298ec8ad23bf8d1696d68778
Bug: 425906323
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6656722
Commit-Queue: Fr <beaufort.francois@gmail.com>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1484331}
beaufortfrancois mentioned this pull request Jul 10, 2025
Draft
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 11, 2025
Bug ??????? - feat(webgpu): allow GPUTextures where `GPUTextureView…
05d67ea 
…`s are allowed r=#webgpu-reviewers!

gpuweb/cts#4407

gpuweb/gpuweb#5228
ErichDonGubler mentioned this pull request Jul 11, 2025
Closed
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 11, 2025
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
bc0a410 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 12, 2025
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
bbcdb1a 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 12, 2025
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
f060d1b 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054

This comment was marked as spam.

Sign in to view
gpuweb deleted a comment from rezadzed Jul 13, 2025
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 16, 2025
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
6dce345 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
ErichDonGubler added a commit to erichdongubler-mozilla/firefox that referenced this pull request Jul 16, 2025
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
b731ac3 
…`s are allowed r=#webgpu-reviewers!

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
lando-worker Bot pushed a commit to mozilla-firefox/firefox that referenced this pull request Jul 17, 2025
Bug 1976960 - feat(webgpu): allow GPUTextures where `GPUTextureView…
f635aec 
…`s are allowed r=webgpu-reviewers,webidl,smaug,nical

Changed in spec. upstream by [gpuweb#5228](gpuweb/gpuweb#5228), tested by CTS in [gpuweb/cts#4407](gpuweb/cts#4407) (which is what caused the `FAIL`s removed here to be introduced with bug 1976874).

Differential Revision: https://phabricator.services.mozilla.com/D257054
beaufortfrancois mentioned this pull request Jul 17, 2025
Open
4 tasks
Chainsawkitten added a commit to Chainsawkitten/WebGPUReconstruct that referenced this pull request Aug 5, 2025
Texture as TextureView
25605fb 
gpuweb/gpuweb#5228 allows using GPUTexture instead of GPUTextureView in a number of places.
juj added a commit to juj/wasm_webgpu that referenced this pull request Sep 12, 2025
IDL: Allow GPUTexture where GPUTextureView is used. gpuweb/gpuweb#5228
02cdc42 
No functional changes since the object types are not strongly checked in the Wasm -> JS bridge.
kainino0x mentioned this pull request Dec 10, 2025
Open
8 tasks
kainino0x mentioned this pull request Jul 27, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

kainino0x kainino0x approved these changes
toji toji approved these changes
dneto0 dneto0 approved these changes

Assignees

No one assigned

Labels

needs-cts-issue This change requires tests (or would need tests if accepted), but may not have a CTS issue filed yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Feature Request: Let you pass a GPUTexture everywhere a GPUTextureView is currently used

5 participants

Back | FazBrowse Home | New Git URL