FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat: all paths between two nodes by SemyonSinchenko · Pull Request #828 · graphframes/graphframes · GitHub

/ graphframes Public

feat: all paths between two nodes - #828

Merged
SemyonSinchenko merged 10 commits into
graphframes:mainfrom
SemyonSinchenko:200-all-paths
Jun 10, 2026
ConversationCommits (10)ChecksFiles changed
Merged

feat: all paths between two nodes#828
SemyonSinchenko merged 10 commits into
graphframes:mainfrom
SemyonSinchenko:200-all-paths

Conversation

SemyonSinchenko commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

What changes were proposed in this pull request?

A simple wrapper over AggregateNeighbors for enumerating all paths between two nodes.

Why are the changes needed?

Close #200

P.S. PySpark + Docs after pre-approve of the API

SemyonSinchenko self-assigned this Apr 29, 2026

james-willis commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Should the 0 hop path be returned? BFS would return that 0 hop path

SemyonSinchenko commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

Should the 0 hop path be returned? BFS would return that 0 hop path

What is zer-hop path between two nodes? Is it a self-loop in the case both source and target are the same? Does it make any sense?

james-willis commented May 8, 2026

Copy link
Copy Markdown
Collaborator

yes the 0 hop path is the self loop. maybe it is a 1-hop case...

SemyonSinchenko commented May 8, 2026

Copy link
Copy Markdown
Collaborator Author

yes the 0 hop path is the self loop. maybe it is a 1-hop case...

And to get it user must specify srcExpression === dstExpression that would be strange. I do not see any reasons to support it tbh. For cycles detection we have a standalone algorithm. I do not see this API as an API for detecting cycles.

james-willis commented May 9, 2026

Copy link
Copy Markdown
Collaborator

I see so since we dont support cycles we dont support loops.

SemyonSinchenko merged commit 360ffe5 into graphframes:main Jun 10, 2026
8 checks passed
SemyonSinchenko deleted the 200-all-paths branch June 10, 2026 18:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

james-willis james-willis approved these changes
+1 more reviewer
megawatimjfh188-code megawatimjfh188-code approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

SemyonSinchenko

Labels

scala

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: all paths between two nodes

3 participants

Back | FazBrowse Home | New Git URL