FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add child lock for tplink thermostats by rytilahti · Pull Request #129649 · home-assistant/core · GitHub

Repository navigation

Add child lock for tplink thermostats - #129649

Merged
joostlek merged 1 commit into
devfrom
tplink/feat/child_lock
Nov 5, 2024
Merged

joostlek merged 1 commit into
devfrom
tplink/feat/child_lock

Conversation

rytilahti commented Nov 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Proposed change

This PR adds a child lock switch for tplink thermostats.

Marking as draft as this depends on python-kasa/python-kasa#1141 .

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

home-assistant Bot commented Nov 1, 2024

Copy link
Copy Markdown
Contributor

Hey there @bdraco, @sdb9696, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tplink can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tplink Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Copy Markdown
Member Author

Required version bump shipped in #129817, so marking this as ready for review.

rytilahti marked this pull request as ready for review November 4, 2024 23:17
rytilahti requested a review from bdraco as a code owner November 4, 2024 23:17
joostlek removed the waiting-for-upstream We're waiting for a change upstream label Nov 5, 2024
joostlek merged commit 72bcc67 into dev Nov 5, 2024
joostlek deleted the tplink/feat/child_lock branch November 5, 2024 10:14
github-actions Bot locked and limited conversation to collaborators Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL