Repository navigation
Add childprotection module - #1141
Merged
rytilahti merged 6 commits intoNov 1, 2024
Merged
rytilahti merged 6 commits into
rytilahti merged 6 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
rytilahti
marked this pull request as ready for review
November 1, 2024 18:49
Copy link
Copy Markdown
Member
Author
|
Looks like the necessary data was available in the sysinfo after all, so there's no need to poll the child device for that, and this should be good to go. |
Sorry, something went wrong.
Copy link
Copy Markdown
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1141 +/- ##
==========================================
+ Coverage 92.55% 92.57% +0.01%
==========================================
Files 100 101 +1
Lines 6607 6624 +17
Branches 708 708
==========================================
+ Hits 6115 6132 +17
Misses 370 370
Partials 122 122 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
1 of 19 tasks
sdb9696
approved these changes
Nov 1, 2024
sdb9696
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Minor nits. I think for consistency use self.data. Testing the setter is your call.
Sorry, something went wrong.
Comment thread
kasa/smart/modules/childprotection.py
Outdated
Comment thread
kasa/tests/smart/modules/test_childprotection.py
rytilahti
commented
Nov 1, 2024
Comment thread
kasa/tests/fakeprotocol_smart.py
Merged
sdb9696
added a commit
that referenced
this pull request
Nov 4, 2024
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04) [Full Changelog](0.7.6...0.7.7) **Release summary:** - Bugfix for child device device creation error with credentials_hash - PIR support for iot dimmers and wall switches. - Various small enhancements and project improvements. **Implemented enhancements:** - Add PIR&LAS for wall switches mentioning PIR support [\#1227](#1227) (@rytilahti) - Expose ambient light setting for iot dimmers [\#1210](#1210) (@rytilahti) - Expose PIR enabled setting for iot dimmers [\#1174](#1174) (@rytilahti) - Add childprotection module [\#1141](#1141) (@rytilahti) - Initial trigger logs implementation [\#900](#900) (@rytilahti) **Fixed bugs:** - Fix AES child device creation error [\#1220](#1220) (@sdb9696) **Project maintenance:** - Update TC65 fixture [\#1225](#1225) (@rytilahti) - Update smartcamera fixtures from latest dump\_devinfo [\#1224](#1224) (@sdb9696) - Add component queries to smartcamera devices [\#1223](#1223) (@sdb9696) - Update try\_connect\_all to be more efficient and report attempts [\#1222](#1222) (@sdb9696) - Use stacklevel=2 for warnings to report on callsites [\#1219](#1219) (@rytilahti) - parse\_pcap\_klap: various code cleanups [\#1138](#1138) (@rytilahti)
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
When turned on, rotating the thermostat will not change the target temperature.
pillarsdotnet
pushed a commit
to pillarsdotnet/python-kasa
that referenced
this pull request
Oct 22, 2026
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04) [Full Changelog](python-kasa/python-kasa@0.7.6...0.7.7) **Release summary:** - Bugfix for child device device creation error with credentials_hash - PIR support for iot dimmers and wall switches. - Various small enhancements and project improvements. **Implemented enhancements:** - Add PIR&LAS for wall switches mentioning PIR support [\python-kasa#1227](python-kasa#1227) (@rytilahti) - Expose ambient light setting for iot dimmers [\python-kasa#1210](python-kasa#1210) (@rytilahti) - Expose PIR enabled setting for iot dimmers [\python-kasa#1174](python-kasa#1174) (@rytilahti) - Add childprotection module [\python-kasa#1141](python-kasa#1141) (@rytilahti) - Initial trigger logs implementation [\python-kasa#900](python-kasa#900) (@rytilahti) **Fixed bugs:** - Fix AES child device creation error [\python-kasa#1220](python-kasa#1220) (@sdb9696) **Project maintenance:** - Update TC65 fixture [\python-kasa#1225](python-kasa#1225) (@rytilahti) - Update smartcamera fixtures from latest dump\_devinfo [\python-kasa#1224](python-kasa#1224) (@sdb9696) - Add component queries to smartcamera devices [\python-kasa#1223](python-kasa#1223) (@sdb9696) - Update try\_connect\_all to be more efficient and report attempts [\python-kasa#1222](python-kasa#1222) (@sdb9696) - Use stacklevel=2 for warnings to report on callsites [\python-kasa#1219](python-kasa#1219) (@rytilahti) - parse\_pcap\_klap: various code cleanups [\python-kasa#1138](python-kasa#1138) (@rytilahti)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When turned on, rotating the thermostat will not change the target temperature.