Repository navigation
Add PIR&LAS for wall switches mentioning PIR support - #1227
rytilahti merged 4 commits into
Conversation
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ Additional details and impacted files @@ Coverage Diff @@
## master #1227 +/- ##
==========================================
- Coverage 92.60% 92.57% -0.03%
==========================================
Files 99 101 +2
Lines 6558 6629 +71
Branches 703 709 +6
==========================================
+ Hits 6073 6137 +64
- Misses 364 370 +6
- Partials 121 122 +1 ☔ View full report in Codecov by Sentry. |
Sorry, something went wrong.
sdb9696
left a comment
There was a problem hiding this comment.
Great PR!
Sorry, something went wrong.
|
I'll add a test for this behavior after receiving a confirmation, that it works as expected. |
Sorry, something went wrong.
|
Genius!! It works as expected when using in a script by getting the "pir_enabled" feature. It also now shows on the modules list. I'm now able to toggle the switches PIR :) Not that I need it, but it doesn't work using the cli kasa command, it still shows "no feature by name 'pir_enabled'". |
Sorry, something went wrong.
|
Thanks for reporting back! Do you see the feature (and the modules) listed in the status output of the cli tool? If you use --debug, do you see the PIR responses in the logs? We obviously want to fix that, but it can be done in a separate PR, so let's merge this already. |
Sorry, something went wrong.
|
I don't see the PIR or ambient features or modules when using the cli tool: Edit: I needed to run uv run kasa as I was trying to use the pip version that didn't have the changes applied. All is working as expected. |
Sorry, something went wrong.
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04) [Full Changelog](0.7.6...0.7.7) **Release summary:** - Bugfix for child device device creation error with credentials_hash - PIR support for iot dimmers and wall switches. - Various small enhancements and project improvements. **Implemented enhancements:** - Add PIR&LAS for wall switches mentioning PIR support [\#1227](#1227) (@rytilahti) - Expose ambient light setting for iot dimmers [\#1210](#1210) (@rytilahti) - Expose PIR enabled setting for iot dimmers [\#1174](#1174) (@rytilahti) - Add childprotection module [\#1141](#1141) (@rytilahti) - Initial trigger logs implementation [\#900](#900) (@rytilahti) **Fixed bugs:** - Fix AES child device creation error [\#1220](#1220) (@sdb9696) **Project maintenance:** - Update TC65 fixture [\#1225](#1225) (@rytilahti) - Update smartcamera fixtures from latest dump\_devinfo [\#1224](#1224) (@sdb9696) - Add component queries to smartcamera devices [\#1223](#1223) (@sdb9696) - Update try\_connect\_all to be more efficient and report attempts [\#1222](#1222) (@sdb9696) - Use stacklevel=2 for warnings to report on callsites [\#1219](#1219) (@rytilahti) - parse\_pcap\_klap: various code cleanups [\#1138](#1138) (@rytilahti)
Some devices (like KS200M) support ambient and motion, but as they are detected as wall switches, they don't get the modules added. This PR enables the respective modules for wall switches when the `dev_name` contains `PIR`.
## [0.7.7](https://github.com/python-kasa/python-kasa/tree/0.7.7) (2024-11-04) [Full Changelog](python-kasa/python-kasa@0.7.6...0.7.7) **Release summary:** - Bugfix for child device device creation error with credentials_hash - PIR support for iot dimmers and wall switches. - Various small enhancements and project improvements. **Implemented enhancements:** - Add PIR&LAS for wall switches mentioning PIR support [\python-kasa#1227](python-kasa#1227) (@rytilahti) - Expose ambient light setting for iot dimmers [\python-kasa#1210](python-kasa#1210) (@rytilahti) - Expose PIR enabled setting for iot dimmers [\python-kasa#1174](python-kasa#1174) (@rytilahti) - Add childprotection module [\python-kasa#1141](python-kasa#1141) (@rytilahti) - Initial trigger logs implementation [\python-kasa#900](python-kasa#900) (@rytilahti) **Fixed bugs:** - Fix AES child device creation error [\python-kasa#1220](python-kasa#1220) (@sdb9696) **Project maintenance:** - Update TC65 fixture [\python-kasa#1225](python-kasa#1225) (@rytilahti) - Update smartcamera fixtures from latest dump\_devinfo [\python-kasa#1224](python-kasa#1224) (@sdb9696) - Add component queries to smartcamera devices [\python-kasa#1223](python-kasa#1223) (@sdb9696) - Update try\_connect\_all to be more efficient and report attempts [\python-kasa#1222](python-kasa#1222) (@sdb9696) - Use stacklevel=2 for warnings to report on callsites [\python-kasa#1219](python-kasa#1219) (@rytilahti) - parse\_pcap\_klap: various code cleanups [\python-kasa#1138](python-kasa#1138) (@rytilahti)
Some devices (like KS200M) support ambient and motion, but as they are detected as wall switches, they don't get the modules added.
This PR enables the respective modules for wall switches when the dev_name contains PIR.
Fixes #1226