FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Move the sanitizer to purely be a filter. by gsnedders · Pull Request #110 · html5lib/html5lib-python · GitHub

/ html5lib-python Public

Move the sanitizer to purely be a filter. - #110

Merged
gsnedders merged 4 commits into
html5lib:masterfrom
gsnedders:sanitizer-fixes-72
May 18, 2016
ConversationCommits (4)ChecksFiles changed
Merged

Move the sanitizer to purely be a filter.#110
gsnedders merged 4 commits into
html5lib:masterfrom
gsnedders:sanitizer-fixes-72

Conversation

gsnedders commented Aug 27, 2013 •
edited
Loading

Copy link
Copy Markdown
Member

This drops support for the tokenizing side of thing, which is sadly the only side that works in previous releases. Fixes #72. See all discussion there.

hoppipolla-critic-bot commented Aug 27, 2013

Copy link
Copy Markdown

Critic review: https://critic.hoppipolla.co.uk/r/287

This is an external review system which you may optionally use for the code review of your pull request.

gsnedders mentioned this pull request May 29, 2014
Closed
blag mentioned this pull request Jul 1, 2014
Closed
gsnedders mentioned this pull request May 5, 2015
Closed
gsnedders mentioned this pull request Aug 10, 2015
Closed
gsnedders modified the milestone: 0.99999999 May 8, 2016
gsnedders force-pushed the sanitizer-fixes-72 branch from 80a1425 to 28bf43b Compare May 9, 2016 15:44
gsnedders force-pushed the sanitizer-fixes-72 branch from 28bf43b to 28fb733 Compare May 17, 2016 22:10

landscape-bot commented May 17, 2016

Copy link
Copy Markdown


Repository health increased by 0.45% when pulling 28fb733 on gsnedders:sanitizer-fixes-72 into f6741ea on html5lib:master.

gsnedders commented May 17, 2016

Copy link
Copy Markdown
Member Author

I think when squashed this is now ready to land.

landscape-bot commented May 17, 2016

Copy link
Copy Markdown


Repository health increased by 0.46% when pulling f582c58 on gsnedders:sanitizer-fixes-72 into f6741ea on html5lib:master.

gsnedders added 3 commits May 18, 2016 17:48
Fix html5lib#72: rewrite the sanitizer to be a treewalker filter only.
a2917e9 
As we no longer need the sanitizer to be shared between a filter and
a tokenizer, move the entire sanitizer to the filter module.
Reintroduce the old sanitizer testsuite from html5lib-tests
75cf697 
This is imported into this repo as its expectations are very much
implementation dependent, with expectations amended to match our
actual behaviour.
Make the serializer behave like a normal func with unknown kwargs
57dfcae
gsnedders force-pushed the sanitizer-fixes-72 branch from f582c58 to 57dfcae Compare May 18, 2016 16:49

landscape-bot commented May 18, 2016

Copy link
Copy Markdown


Repository health increased by 0.46% when pulling 57dfcae on gsnedders:sanitizer-fixes-72 into f6741ea on html5lib:master.

gsnedders merged commit 8cb66f2 into html5lib:master May 18, 2016
gsnedders mentioned this pull request May 18, 2016
Merged
mgilson reviewed May 20, 2016
View reviewed changes
Comment thread html5lib/filters/sanitizer.py
# Remove attributes with disallowed URL values
for attr in (attr_names & self.attr_val_is_uri):
assert attr in attrs
# I don't have a clue where this regexp comes from or why it matches those

mgilson May 20, 2016 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It looks like this regex is trying to remove:

`                Literal backtic...
\x00-\x20        Ascii table characters starting at NULL up to and including Space -- Mostly non-printable characters...
\x7f-\xa0        Bytes with values 127 (DELETE) -> 160.  More non-printable characters...
\s               Whitespace

I don't know why it would be doing these things ...

gsnedders May 20, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

My assumption is it's something to do with legacy attribute parsing in old UAs, for whom such characters can alter parsing.

gsnedders deleted the sanitizer-fixes-72 branch May 20, 2016 17:18
gsnedders added a commit to gsnedders/html5lib-python that referenced this pull request May 22, 2016
Remove ability to use a custom tokenizer
8999da0 
This should be unneeded since the sanitizer changes (html5lib#110)
gsnedders added a commit to gsnedders/html5lib-python that referenced this pull request Jul 6, 2016
Remove ability to use a custom tokenizer
d8d5bb6 
This should be unneeded since the sanitizer changes (html5lib#110)
gsnedders mentioned this pull request Jul 15, 2016
Closed
jonathanmorgan mentioned this pull request Aug 17, 2016
Closed
mrmachine mentioned this pull request Oct 7, 2016
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

0.99999999

Development

Successfully merging this pull request may close these issues.

Sanitizing filter broken in 0.90

4 participants

Back | FazBrowse Home | New Git URL