Repository navigation
Use python sets - #158
Use python sets#158blag wants to merge 1 commit into
Conversation
Sorry, something went wrong.
|
Critic review: https://critic.hoppipolla.co.uk/r/1615 This is an external review system which you may optionally use for the code review of your pull request. In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request. |
Sorry, something went wrong.
|
Can you have each branch based on upstream master, so you don't have massive overlap between PRs? Note that #110 makes large changes to the sanitizer — including changing the lists to sets. |
Sorry, something went wrong.
|
Sorry I'm still new to using Github's pull requests. This is fixed. And yes, this is superseded by #110. |
Sorry, something went wrong.
|
Per above, superseded. |
Sorry, something went wrong.
Instead of
for (loop): if (condition): continuesimply use Python sets:
for attr in set(attrs.keys()).intersection(set(self.attr_val_is_uri)): ...