V2.2.02 by glesur · Pull Request #355 · idefix-code/idefix · GitHub

Changed

Added a module to add explicit units (Add units #338)
fixed a bug that could lead to incorrect profiling information on non-blocking cuda loops (fix profiling on GPUs #341)
fixed a bug that could lead to incorrect energy budget when shearing box and fargo were both enabled (fix the energetic of ShearingBox+Fargo #346)
fixed a bug that led to incorrect BX2 reconstruction when axis is not used on both sides of the domain (Fix axis and reflective boundary conditions #345)
fixed a bug that led to incorrect reflective boundary conditions on B when DIMENSIONS < 3 (Fix axis and reflective boundary conditions #345)
fixed a bug that led to incorrect dust stopping time when the adiabatic equation of state is used with "size" drag law (fix "size" drag force #353)

Added

documentation for the continuous integration (Doc updates #354)

…lay which slope limiter is used, fixed typo in the braginskii doc

updated ShowConfig functions from braginskii tc and viscosity to disp…

update changelog and version in develop

checking that everything works as expected)

…diffusion

Fix SYCL loop auto-configuration

Improve div B check

fix axis current regularisation along the south pole

Improve Wallclock dump outputs and add documentation (this feature has been around since 2.0.05, but not referenced)

…ing (#341)

* fix the energetic of ShearingBox+Fargo The work done by the gravity force was not properly removed when using fargo

* fix axis BX2s reconstruction when axis is not used on both sides of the X2 domain (#342) * fix reflective with MHD and DIMENSIONS < 3 (#343)

…as (#353)

Pull Request Overview

This pull request upgrades Idefix to version 2.2.02, incorporating several bug fixes and a new units module for explicit unit conversions. The changes address critical issues in profiling, energy budget calculations, boundary conditions, and magnetic field reconstruction while adding comprehensive documentation for continuous integration testing.

Key changes:

Added a units module that provides explicit unit conversion capabilities in CGS system
Fixed multiple bugs related to profiling, energy budget, boundary conditions, and dust physics
Enhanced documentation for continuous integration testing workflows

Reviewed Changes

Copilot reviewed 22 out of 22 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/units.hpp	New header defining the Units class with CGS constants and unit conversion methods
src/units.cpp	Implementation of Units class methods for initialization and unit calculations
src/main.cpp	Integration of units module into main application workflow
src/gravity/gravity.cpp	Enhanced gravity module to support unit-based gravitational constant calculation
src/global.hpp/cpp	Added global units object and profiling fence fix
src/fluid/drag.hpp	Fixed parentheses placement in dust stopping time calculation
src/fluid/calcRightHandSide.hpp	Corrected energy budget calculation for Fargo+shearing box scenarios
src/fluid/boundary/boundary.hpp	Improved BX2 reconstruction and reflective boundary condition handling
src/fluid/boundary/axis.hpp/cpp	Refactored axis boundary handling and removed debug output
src/fluid/addSourceTerms.hpp	Removed duplicate Fargo source term causing energy budget issues
doc/source/*	Added comprehensive CI testing documentation
CMakeLists.txt	Updated version numbers and build configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Pull Request Overview

Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/fluid/boundary/axis.hpp:1

Removed debug output statement that was likely left over from development. This change improves code cleanliness by removing unnecessary console output.

// ***********************************************************************************

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

vreville and others added 30 commits December 3, 2024 10:57

Added new branch with collisionless TC from develop

72244f8

Fixed undeclared CL arrays (GPU compiling)

cb3bea8

collisionless tc as an option of bragTDiffusion

6ec6d0d

idefix error includes collisionless status

9ac6698

Added a saturation option for collisionless formulation

94a71d2

add a column Density example

e2f7a9a

add some documentation

26ffc60

add it to the tests

a1e6e67

imrove documentation

9c58596

add doc link for column density

6283fd5

missing testme file

8277ed0

add a 3D interface for column density computation

31ae1b8

Upwind scheme for cless TC with limiters + tests

d656036

fix dimensions for alias

7c10ec0

updated ShowConfig functions from braginskii tc and viscosity to disp…

79e70cf

…lay which slope limiter is used, fixed typo in the braginskii doc

Merge pull request #1 from jeankpf/collisionlessTC

c1cd824

updated ShowConfig functions from braginskii tc and viscosity to disp…

Merge pull request #316 from idefix-code/V2.2.00

4286299

update changelog and version in develop

Génération automatique de plots de performance dans la doc

d0f348a

Updated doc for Collisionless TC

a61eb61

Corrected doc typo

7bef7a9

Corrected typo

8f48bc2

add global routines to dump Idefix arrays (useful for debugging or

1f891c7

checking that everything works as expected)

add missing header

afc3e4d

revert back to old reference commit sha to avoid merge conflicts

e840e2f

go back to last reference before fork

ac10470

Récupération des derniers benchmarks sur JeanZay

76e399a

Récupération de benchs pour H100; ajout de labels aux axes

49a56ee

[pre-commit.ci lite] apply automatic fixes

0cb52ea

Use a std::vector of IdefixArray as input for the userdef braginskii …

0c07a8e

…diffusion

corrected typo

250610a

glesur added 21 commits March 12, 2025 14:32

do this for all loops

9d7c589

catch misbehaved loops earlier (fix cuda!), and be more explicit.

217a812

cleaning up

e58f724

Merge pull request #331 from idefix-code/fixSyclConfig

4c8ccb8

Fix SYCL loop auto-configuration

fix axis current regularisation along the south pole

939f0cd

make divB check diemsionless

8e0481e

Merge pull request #334 from idefix-code/improveDivB

bfc1aca

Improve div B check

Merge pull request #333 from idefix-code/fixJaxis

1c33a03

fix axis current regularisation along the south pole

use one single extra parameter for dump time output

d894627

add doc for wallclock dump outputs

83986d0

Improve Wallclock dump outputs

2529e80

Improve Wallclock dump outputs and add documentation (this feature has been around since 2.0.05, but not referenced)

Merge branch 'master' into develop

28ff697

Add units (#338 )

1be4115

add Kokkos::fence at the beginning of profiling regions to fix profil…

e4b5a83

…ing (#341)

fix the energetic of ShearingBox+Fargo (#346 )

b22cd25

* fix the energetic of ShearingBox+Fargo The work done by the gravity force was not properly removed when using fargo

Fix axis and reflective boundary conditions (#345 )

81f9143

* fix axis BX2s reconstruction when axis is not used on both sides of the X2 domain (#342) * fix reflective with MHD and DIMENSIONS < 3 (#343)

fix "size" drag force with adiabatic equation of state (sound speed w…

bea1c7b

…as (#353)

Doc updates (#354 )

cde3a14

update changelog for new release

0446afc

update version #

60f1645

incorrect issue #

10f91c6

glesur requested a review from Copilot October 18, 2025 18:39

Copilot AI reviewed Oct 18, 2025

View reviewed changes

Comment thread src/units.hpp Outdated

Comment thread src/units.hpp Outdated

Comment thread doc/source/reference/idefix.ini.rst Outdated

Comment thread doc/source/reference/idefix.ini.rst Outdated

glesur and others added 3 commits October 18, 2025 20:52

Update src/units.hpp

b6c24d6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update src/units.hpp

697c13c

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update doc/source/reference/idefix.ini.rst

73547fe

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

glesur requested a review from Copilot October 18, 2025 19:30

Copilot AI reviewed Oct 18, 2025

View reviewed changes

Comment thread src/global.cpp

glesur merged commit 4a8b8a2 into master Oct 19, 2025
38 checks passed

glesur deleted the v2.2.02 branch April 22, 2026 08:16

V2.2.02 by glesur · Pull Request #355 · idefix-code/idefix · GitHub

Repository navigation

V2.2.02 - #355

V2.2.02#355
glesur merged 105 commits into
masterfrom
v2.2.02

glesur commented Oct 18, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

V2.2.02 by glesur · Pull Request #355 · idefix-code/idefix · GitHub

Repository navigation

V2.2.02 - #355

V2.2.02#355glesur merged 105 commits intomasteridefix-code/idefix:masterfrom v2.2.02idefix-code/idefix:v2.2.02Copy head branch name to clipboard

Conversation

glesur commented Oct 18, 2025

Changed

Added

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

V2.2.02#355
glesur merged 105 commits into
masterfrom
v2.2.02