Move over to controller-runtime over doing it ourselves - #348
Merged
davidcollom merged 6 commits intoMar 31, 2025
Merged
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
davidcollom
force-pushed
the
controller-runtime
branch
from
9932d88 to
d4c2307
Compare
March 27, 2025 15:39
Copy link
Copy Markdown
Collaborator
Author
|
Some Screenshots of our findings.... Here's our last 2 days where version-checker was running for several days: Here's a closer look at the memory utilisation: And the GoRoutines: After: With a lot of this in mind, we've ensured that CPU usage/profile has not changed (%age is calculated towards 1 full CPU - I.E: 200m=0.2%) :
|
Sorry, something went wrong.
davidcollom
requested review from
BeckyPauley,
aidy,
cyberbliss,
hawksight and
joshw123
March 27, 2025 15:47
davidcollom
commented
Mar 27, 2025
Comment thread
pkg/client/acr/acr.go
| ) | ||
|
|
||
| type Client struct { | ||
| *http.Client |
Copy link
Copy Markdown
Collaborator
Author
There was a problem hiding this comment.
There's never a http.Client used within ACR - it creates its own - so removing.
Sorry, something went wrong.
davidcollom
force-pushed
the
controller-runtime
branch
from
702a2d6 to
d79df1f
Compare
March 27, 2025 16:30
Copy link
Copy Markdown
Collaborator
Author
|
I discovered a secondary leak where some metrics weren't cleaned up on pod deletion. |
Sorry, something went wrong.
davidcollom
force-pushed
the
controller-runtime
branch
from
4313126 to
83c8fd2
Compare
March 27, 2025 18:48
davidcollom
commented
Mar 31, 2025
Comment thread
pkg/metrics/metrics.go
added 5 commits
March 31, 2025 16:49
davidcollom
force-pushed
the
controller-runtime
branch
from
17f1c82 to
0a2495a
Compare
March 31, 2025 15:53
joshw123
approved these changes
Mar 31, 2025
maria-reynoso
approved these changes
Mar 31, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing we identified that there was significant memory utilisation when running version-checker for 2-3 days we saw that our test cluster was running at ~400+MB when it started off at around 40-60MB.
This PR changes over from manually implemented shared informers and managing the workqueue and its goroutines, to use controller-runtime, this means we don't have to manage as much code/logic and workers ourselves and is managed for us, allowing us to focus more on the purpose of version-checker.
We do believe that there is still a memory leak, however from testing (over 24 hour period) on the same cluster, that memory usage has increased at a much slower rate, additionally we've seen that goroutines are staying at a reasonable number, where as previously it was growing exponentially at, what was an alarming rate under some situations.