Remove deprecated ObjectSpace#_id2ref - #9533
Merged
headius merged 5 commits intoJul 20, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
There was a problem hiding this comment.
Pull request overview
This PR removes JRuby’s implementation of the deprecated ObjectSpace._id2ref API to align with Ruby 4.1 behavior (per ruby-lang bug #22135), and simplifies the internal object-id bookkeeping that existed to support _id2ref.
Changes:
- Removed ObjectSpace._id2ref method definitions from RubyObjectSpace.
- Simplified org.jruby.runtime.ObjectSpace by dropping per-object id caching (identitiesByObject) and related id creation helpers.
- Updated object id initialization to always use the global id generator (ObjectSpace.calculateObjectId()), and removed the corresponding Java test for id2ref.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| core/src/test/java/org/jruby/test/TestObjectSpace.java | Removes the Java-level identity/id2ref test that depended on _id2ref-style behavior. |
| core/src/main/java/org/jruby/runtime/ObjectSpace.java | Simplifies id registration and id generation by removing object→id caching. |
| core/src/main/java/org/jruby/runtime/ivars/VariableTableManager.java | Switches object id initialization to always use ObjectSpace.calculateObjectId(). |
| core/src/main/java/org/jruby/RubyObjectSpace.java | Removes the Ruby-visible _id2ref entry point. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sorry, something went wrong.
Comment thread
core/src/main/java/org/jruby/runtime/ObjectSpace.java
Comment thread
core/src/main/java/org/jruby/RubyObjectSpace.java
Comment thread
core/src/test/java/org/jruby/test/TestObjectSpace.java
headius
force-pushed
the
remote_id2ref
branch
3 times, most recently
from
6f2613c to
aa21ef6
Compare
July 17, 2026 21:42
Comment thread
test/jruby/test_objectspace.rb
Outdated
Officially removed for Ruby 4.1. See https://bugs.ruby-lang.org/issues/22135
Copy link
Copy Markdown
Member
Author
|
Remaining failures are due to Ruby 4.1 functionality that has not yet been implemented. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Officially removed for Ruby 4.1.
See https://bugs.ruby-lang.org/issues/22135