| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Sorry, something went wrong.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 79b09c0. Configure here.
Sorry, something went wrong.
Co-Authored-By: rlamb@launchdarkly.com <4955475+kinyoklion@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
Implements the OpenFeature tracking API (spec §6) in the provider, matching the behavior of the Java, .NET, and Node providers.
Requirements
Related issues
None; found while auditing the LaunchDarkly OpenFeature providers for missing spec features.
Describe the solution you've provided
LaunchDarklyProvider.track converts the OpenFeature evaluation context to an ldclient.Context with the existing EvaluationContextConverter and then calls the narrowest LDClient.track overload that fits the details supplied: name only, name + data, or name + data + metric value.
Describe alternatives you've considered
Sending an event with an empty/invalid context when no context is supplied, which would produce events LaunchDarkly cannot attribute. The Java provider already logs and skips in this case, so this follows that precedent.
Additional context
Implementation detailsTrackingEventDetails.attributes defaults to {} rather than None, so an empty attribute map is normalized to None to avoid sending an empty data object. Tests patch LDClient.track and assert the exact argument shape for each of the four combinations (no context, no details, attributes only, value + attributes, value only).
Link to Devin session: https://app.devin.ai/sessions/0c452d209ec54b068ba120b4c92b8f6c
Requested by: @kinyoklion
Note
Overview
Implements OpenFeature spec tracking on LaunchDarklyProvider so client.track(...) forwards custom events to LaunchDarkly instead of being dropped when the provider had no track implementation.
track converts the OpenFeature EvaluationContext via the existing converter and calls LDClient.track with the right arity: event name only, plus data from TrackingEventDetails.attributes, and/or metric_value from TrackingEventDetails.value (empty attribute maps are treated as no data). Calls without an evaluation context log at info on launchdarkly-openfeature-server and send nothing.
Dependency: openfeature-sdk minimum is raised from 0.8.0 to 0.9.0. Tests mock LDClient.track for the no-context, no-details, attributes-only, value-only, and value+attributes paths.
Reviewed by Cursor Bugbot for commit 9d846a4. Bugbot is set up for automated code reviews on this repo. Configure here.