Repository navigation
[maint/v0.21] Fix build of tests with mingw - #2770
Merged
ethomson merged 1 commit intoDec 21, 2014
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
very, very partial backport of 2f795d8 to maint/v0.21 branch without this include, O_RDWR and O_CREAT are undeclared when building tests/path/win32.c with mingw
Copy link
Copy Markdown
Member
|
👍 Thanks for this! I was just lurching around trying to figure out why my mingw environment didn't work. I'm exceptionally thankful to not have to do this. 🌟 🌟 🌟 |
Sorry, something went wrong.
ethomson
added a commit
that referenced
this pull request
Dec 21, 2014
[maint/v0.21] Fix build of tests with mingw
Copy link
Copy Markdown
Contributor
Author
|
HTH. cmn figured out most of what was wrong the other day in #2766. Keep up the good work! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
very, very partial backport of 2f795d8 to maint/v0.21 branch
without this include (or equivalent in some other location), O_RDWR and O_CREAT are undeclared when building tests/path/win32.c with mingw
ref #2766 for discussion