| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
|
This is very minor: I wonder if it would be clearer to write this as if (error == GIT_EEXISTS) continue? This may help us in the future if we want to add additional logic to do with the remote, as right now the conditional seems to be about whether to call the callbacks, but we really want to stop all processing if the ref already existed. If there's additional processing in the future then it may make it more clear. Thanks again for tackling this - and apologies for the delay in reviewing. |
Sorry, something went wrong.
|
Yeah, that makes sense. Updated accordingly. |
Sorry, something went wrong.
|
And thanks for the review! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
When an existing tag is changed on the remote, the default (autotag) behavior is to not overwrite the local tag, but the update callback is still called as if the tag had been updated. This commit fixes that.