Repository navigation
Fixed bug while parsing INT64_MIN - #3846
Merged
ethomson merged 1 commit intoJul 5, 2016
Merged
ethomson merged 1 commit into
ethomson merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Looks good to me, thanks for the fix. The AppVeyor failure is unrelated, so I'd consider this PR good to go (even though it should be squashed when pulled). |
Sorry, something went wrong.
rkrp
force-pushed
the
fix_bug_parsing_int64min
branch
from
bccb850 to
70b9b84
Compare
June 29, 2016 08:09
Copy link
Copy Markdown
Contributor
Author
|
@pks-t Squashed the commits. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@rkrp Thanks. Wouldn't have been necessary, though, as GitHub recently introduced a feature to auto-squash commits when a pull request is accepted. But can't hurt if you do it ;) |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug which caused strtol() to fail parsing INT64_MIN. Addressed in #3817.
Added test cases in tests/core/strtol.c to check for the boundary values.