Repository navigation
Fix leaks, some warnings and an error - #3865
Merged
ethomson merged 9 commits intoAug 2, 2016
Merged
ethomson merged 9 commits into
ethomson merged 9 commits into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
ethomson
force-pushed
the
ethomson/leaks
branch
3 times, most recently
from
a53e688 to
3527761
Compare
July 22, 2016 18:02
added 8 commits
July 24, 2016 15:49
Compare the preimage to the image; don't compare the preimage to itself.
After 1cd6599, we were passing a pointer to an `unsigned long` to a function that now expected a pointer to a `size_t`. These types differ on 64-bit Windows, which means that we trash the stack. Use `size_t`s in the packbuilder to avoid this.
And give it a default so that some compilers don't (unnecessarily) complain.
Copy link
Copy Markdown
Member
Author
|
Having Windows 64 be completely broken is bumming me out. I'm going to merge this later today so that we can get through the backlog of pull requests that have piled up. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some leaks, and, oh, right, a terrible buffer overflow that I introduced in 1cd6599.